From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id +FLNN4UAT2JjbAAAWB0awg (envelope-from ) for ; Thu, 07 Apr 2022 11:17:25 -0400 Received: by simark.ca (Postfix, from userid 112) id E28C71F344; Thu, 7 Apr 2022 11:17:25 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 62A631E150 for ; Thu, 7 Apr 2022 11:17:25 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1CDAC3857811 for ; Thu, 7 Apr 2022 15:17:25 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1CDAC3857811 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1649344645; bh=Qlagf23EHgnj5UNEdJIm+fq2iHNPstLwXEPqPpNRUJE=; h=To:Subject:In-Reply-To:References:Date:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=OTbeiHZkA46oIwCf4OdWHIwM+bIGXbgB3Nvz7F5SJuIzEow0fr05MTTxEw+BR3yxJ ZN/vk10FAk2cqLDicaj3UWjVP5HxrQ3NQgh29SNj4P3Dv5lKVfKDuZwtqUv+31U5TZ wd/qhfr7cyMB4cRp5YPk11sV9KYOqg63FQmCDDrs= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 1DB7C385782C for ; Thu, 7 Apr 2022 15:16:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1DB7C385782C Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-500-KmpCbJSiP5CULoCyQK98dA-1; Thu, 07 Apr 2022 11:16:54 -0400 X-MC-Unique: KmpCbJSiP5CULoCyQK98dA-1 Received: by mail-wm1-f69.google.com with SMTP id m31-20020a05600c3b1f00b0038e98dd534aso401120wms.2 for ; Thu, 07 Apr 2022 08:16:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:in-reply-to:references:date :message-id:mime-version; bh=Qlagf23EHgnj5UNEdJIm+fq2iHNPstLwXEPqPpNRUJE=; b=b8k6hJjOYpimfivC92l6JVsSVNulgbQi76mEPZtij4V2RZCZLs4FD2wnaaNx9pC1dw 5CcE9UUKeEaMC46FCTmmqhEcM+0UZiYjybRbsAFqMD8CI2LXpG9Was5TxgvvadYwl/3x 7gMJTxiyjFmgMqbfmEzfswgYqLuZ85WBGERC5HrvFKPM0L/C3RNlGqc+3Kjm8FPdY1qC 527Uo7lkCBDvyqVaNbAXODirvBIVHJrjl5yanAJ7mjvwr7Pbx+Bb7Ypp6pVfNAKBHPhi ECZAm+AJgPZr7rM7U52po3C5VqwuzD6cVN0IO94sP4j6OQCwpWaCWWB/BHoPrKm055Xb GxYA== X-Gm-Message-State: AOAM533sKhvOCrJc3Ie/2F4crwX0Um9dMo/3/ytRnefgJSWUiPFgtaty 7PgdjvZIJkpyKBLkA7nZxQyFMNTTvjmMNCpGdBFHzvOpYXKAf3wCbpVCQ+y9mY3xQMWQqfX9evj IuEKKFj/YN8Zs1Qtyoe5dpQ== X-Received: by 2002:a05:6000:137c:b0:206:17dd:d67d with SMTP id q28-20020a056000137c00b0020617ddd67dmr10741795wrz.288.1649344613137; Thu, 07 Apr 2022 08:16:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxx+zf4E00RBk7ZeI1Q2SSAXY5pYNXBOmzwKO396GOwSTG8VL+uglpeRSXkKXmq+O+QY4z7WA== X-Received: by 2002:a05:6000:137c:b0:206:17dd:d67d with SMTP id q28-20020a056000137c00b0020617ddd67dmr10741785wrz.288.1649344612898; Thu, 07 Apr 2022 08:16:52 -0700 (PDT) Received: from localhost (host86-169-131-113.range86-169.btcentralplus.com. [86.169.131.113]) by smtp.gmail.com with ESMTPSA id h133-20020a1c218b000000b0038e7c143e78sm8257263wmh.45.2022.04.07.08.16.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Apr 2022 08:16:52 -0700 (PDT) To: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCHv2 00/16] Default register groups, and general related cleanup In-Reply-To: References: Date: Thu, 07 Apr 2022 16:16:51 +0100 Message-ID: <877d807wkc.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Andrew Burgess via Gdb-patches Reply-To: Andrew Burgess Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" Simon Marchi via Gdb-patches writes: > On 2022-04-06 08:04, Andrew Burgess via Gdb-patches wrote: >> This work started with this thread: >> >> https://sourceware.org/pipermail/gdb-patches/2022-March/187071.html >> >> In which it was discovered that the ppc targets don't add the default >> register groups during gdbarch initialisation. >> >> I've run into this problem before, and every time I wonder why the >> default register groups aren't added by default in all cases. >> >> So, looked at doing just that. >> >> But the register group management code was feeling a bit crusty, so I >> thought I'd clean it up. >> >> Then I hit some bugs, which I figured I'd fix. >> >> Anyway, patch #9 is what I set out to do. Everything else is me >> trying to improve the register group handling code. >> >> Changes in v2: >> >> - Rebased onto current master, the changes I make to >> gdb.tui/regs.exp in one of the patches needed some small >> adjustments given recent tui changes, >> >> - Updated patch #11 based on Lancelot's feedback, this looks much >> better now. > > Other than the small nits I pointed out, this all LGTM. I left a > comment about maybe using intrusive_list instead of std::vector, if that > could simplify things. But if so, it can be done later / after this > series is merged. Thanks for the review. I addressed the feedback, but left the std::vector / intrusive_list stuff for now. This certainly isn't hot path code, and the vector version just seemed simpler (to me). But if you're keen to change it, then I'm not going to object. Thanks, Andrew