From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id dOhBEkdfBmOPqSwAWB0awg (envelope-from ) for ; Wed, 24 Aug 2022 13:26:31 -0400 Received: by simark.ca (Postfix, from userid 112) id 3A0701E4A7; Wed, 24 Aug 2022 13:26:31 -0400 (EDT) Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=fvO9yCQj; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 387D41E21F for ; Wed, 24 Aug 2022 13:26:30 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 76DF53851157 for ; Wed, 24 Aug 2022 17:26:29 +0000 (GMT) Received: from gproxy1-pub.mail.unifiedlayer.com (gproxy1-pub.mail.unifiedlayer.com [69.89.25.95]) by sourceware.org (Postfix) with ESMTPS id D4FD33851A9B for ; Wed, 24 Aug 2022 17:26:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D4FD33851A9B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw10.mail.unifiedlayer.com (unknown [10.0.90.125]) by progateway3.mail.pro1.eigbox.com (Postfix) with ESMTP id 42F041004BFEB for ; Wed, 24 Aug 2022 17:26:04 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id Qu8hobkfZCokGQu8iobkOb; Wed, 24 Aug 2022 17:26:04 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=c8Nu/Txl c=1 sm=1 tr=0 ts=63065f2c a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=biHskzXt2R4A:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=p_StZh2jjSWcMAv3HBYA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=+08QQQxNcegPYT3oFAeLyMoiteeolssmZc/TaM3j42o=; b=fvO9yCQjD1XmyUPTKpEYo+9KUx xvouSWylfGyIDHhZhgXdk9dVH1WLeNk55zrfRFafTuGQwMGpVhmDhWyChXpMWXZea4H43AwcUlWvb TMPQES7oVLtxjqlbKp8dhxFEG; Received: from 71-211-185-105.hlrn.qwest.net ([71.211.185.105]:35580 helo=prentzel) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oQu8h-0013EN-KE; Wed, 24 Aug 2022 11:26:03 -0600 From: Tom Tromey To: Patrick Monnerat Subject: Re: [PATCH] gdb: add a file event mask parameter to add_file_handler References: <20220819174601.144876-1-patrick@monnerat.net> <874jy2dbf6.fsf@tromey.com> <1f5cd3c2-9552-c75a-1add-e3ceebc63e3e@monnerat.net> X-Attribution: Tom Date: Wed, 24 Aug 2022 11:26:02 -0600 In-Reply-To: <1f5cd3c2-9552-c75a-1add-e3ceebc63e3e@monnerat.net> (Patrick Monnerat's message of "Wed, 24 Aug 2022 17:26:25 +0200") Message-ID: <877d2xtuxh.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.185.105 X-Source-L: No X-Exim-ID: 1oQu8h-0013EN-KE X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-185-105.hlrn.qwest.net (prentzel) [71.211.185.105]:35580 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tom Tromey , Patrick Monnerat via Gdb-patches Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" >> Is there ever a situation where this can happen and it is not a bug in >> the caller? I am wondering if this ought to be an assert instead. Patrick> Yes. In Insight, command input from stdin is disabled by setting main_ui-> input_fd to -1. A later call to register_file_handler from Patrick> async_enable_stdin causes add_file_handler to be called with fd = Patrick> -1. Maybe I should add a comment for this. I took this same approach in my DAP implementation, which is why I changed gdb to always call the 'ui' methods to manipulate the event handlers. In my patch I then change these methods to check for the -1 case. I can submit this bit separately next week. Or you can do it, it's trivial. Patrick> I thought so too and did try to use enum_flags! Unfortunately the same Patrick> int field (file_handler::mask) stores either these bits in case of Patrick> select use, or a poll mask as defined by the system when poll is used. Ok, I see. Tom