From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 3AuhOnnhp2Q6ARkAWB0awg (envelope-from ) for ; Fri, 07 Jul 2023 05:57:13 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=J16cIQH0; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id DC13E1E0BD; Fri, 7 Jul 2023 05:57:13 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C34A81E00F for ; Fri, 7 Jul 2023 05:57:11 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C056E385021B for ; Fri, 7 Jul 2023 09:57:10 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C056E385021B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1688723830; bh=sg3VUCUwS2RQ9a9ML9kvCFVryuzgBRmuGl8tDJsTSXk=; h=To:Subject:In-Reply-To:References:Date:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=J16cIQH0EhltZEnoN344mKeCZ1xjrbo1xVHJOE0bL/5OF8XzYk0xUnNJO3nPtqFCk wLEPbtfcv/lH28BesNcAwTj1nxsYzPB2q7IFvr1mf0n/iLb2L9RAJnQnWlzgmZ+mx0 0JSNzfVYIwPWgYzBq1WS7Hyvg/8vpbfiqmmYM2xk= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id EB6CA3850861 for ; Fri, 7 Jul 2023 09:56:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EB6CA3850861 Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-636-0CfZtr4dNvm2czH0s3B2Ng-1; Fri, 07 Jul 2023 05:56:45 -0400 X-MC-Unique: 0CfZtr4dNvm2czH0s3B2Ng-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-31273e0507dso929414f8f.3 for ; Fri, 07 Jul 2023 02:56:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688723804; x=1691315804; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=sg3VUCUwS2RQ9a9ML9kvCFVryuzgBRmuGl8tDJsTSXk=; b=YKpu8eRPtoyJbNyiZel7NYXZEpR0DaJKSRAuJtWVhBgTBWRcVoEqZojxYdBENB0TTJ YkDoRaqvtt0JmCGo1UPv0ZHoQGe5yDH+Z9YxhWCJKowWrqGEE+3uHxsmd3oLJySGfFXz sxdJOxf5e+Hw+TtRcfh3+QMgfTr3PQ9Fs29PLBVP/SPummOsLIsfQW1BclX8KT/DQ4xX DSW2J3/gJPMmQFjuiXhCdBnx1GfVSt7WLb/MwDKEIhR7TJxxHCjnsQYCXy50vd2ISWLT dIE/rzA4R902noPXLLUEvgdyVdmkPtL164wLC5/B5WzCkBo9dCy4BmSrvp5Om17viCZL /YwA== X-Gm-Message-State: ABy/qLbnIfbIhsiIugXCBgGcLbR8jWcAx1myx6Esd8eLLfPDw0TlXmbB qegsyDg/HAudotXjWw2M3WihMkrKCcFp4N2bVDi2WlLmnyGsqcxHsIK/itnLdMbiJeD1CzDRHYW 5r29XYGe24H2T+s+CeIdpdJ2oIww2HQ== X-Received: by 2002:a5d:42c9:0:b0:313:ecd3:7167 with SMTP id t9-20020a5d42c9000000b00313ecd37167mr3493167wrr.42.1688723804356; Fri, 07 Jul 2023 02:56:44 -0700 (PDT) X-Google-Smtp-Source: APBJJlG1Z/clkosEdTZlzpW+mNCAZybjM6xr1Ct7nxzWAvXkNM/5la/mgaSg5UU9a93dVTEQrN+ZOg== X-Received: by 2002:a5d:42c9:0:b0:313:ecd3:7167 with SMTP id t9-20020a5d42c9000000b00313ecd37167mr3493157wrr.42.1688723804021; Fri, 07 Jul 2023 02:56:44 -0700 (PDT) Received: from localhost (2.72.115.87.dyn.plus.net. [87.115.72.2]) by smtp.gmail.com with ESMTPSA id e3-20020a5d5943000000b003141f3843e6sm4010706wri.90.2023.07.07.02.56.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Jul 2023 02:56:43 -0700 (PDT) To: Pedro Alves , gdb-patches@sourceware.org Subject: Re: [PATCH 2/3] gdb/testsuite: add test for core file with a 0 pid In-Reply-To: References: <6cb39b064b3e1c9ed57964b29fd980f3a6d30a25.1685956034.git.aburgess@redhat.com> Date: Fri, 07 Jul 2023 10:56:42 +0100 Message-ID: <877crckpt1.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Andrew Burgess via Gdb-patches Reply-To: Andrew Burgess Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" Pedro Alves writes: > Hi Andrew, > > I'm skimming the thread to catch up, and noticed this: > > On 2023-06-05 10:11, Andrew Burgess via Gdb-patches wrote: >> +++ b/gdb/testsuite/gdb.arch/core-file-pid0.exp >> @@ -0,0 +1,63 @@ >> +# This testcase is part of GDB, the GNU debugger. >> +# >> +# Copyright 2023 Free Software Foundation, Inc. >> +# >> +# This program is free software; you can redistribute it and/or modify >> +# it under the terms of the GNU General Public License as published by >> +# the Free Software Foundation; either version 2 of the License, or >> +# (at your option) any later version. >> +# >> +# This program is distributed in the hope that it will be useful, >> +# but WITHOUT ANY WARRANTY; without even the implied warranty of >> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >> +# GNU General Public License for more details. >> +# >> +# You should have received a copy of the GNU General Public License >> +# along with this program; if not, write to the Free Software >> +# Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. >> + > > Wrong license (GPLv2), and wrong header -- we haven't been using the snail > mail FSF header in years. Ooops. Thanks for spotting this. I pushed the patch below to correct this mistake. Thanks, Andrew --- commit 7c632c2a696fb68e5575db1e2c934788a831e578 Author: Andrew Burgess Date: Fri Jul 7 10:51:53 2023 +0100 gdb/testsuite: fix license on recently added file The license header on a file I recently contributed was incorrect. The file was added in commit: commit 087969169836f802a09b1cd0502d2f22d7a8f7dc Date: Tue May 23 11:25:21 2023 +0100 gdb: handle core files with .reg/0 section names The problems were: - GPLv2 instead of GPLv3, - Use the FSF postal address rather than their URL. Nobody else has touched the file since I merged it, so I don't believe there are any problems with me changing the license, this commit does just that. diff --git a/gdb/testsuite/gdb.arch/core-file-pid0.exp b/gdb/testsuite/gdb.arch/core-file-pid0.exp index 6e91111b44b..56746cca567 100644 --- a/gdb/testsuite/gdb.arch/core-file-pid0.exp +++ b/gdb/testsuite/gdb.arch/core-file-pid0.exp @@ -4,7 +4,7 @@ # # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by -# the Free Software Foundation; either version 2 of the License, or +# the Free Software Foundation; either version 3 of the License, or # (at your option) any later version. # # This program is distributed in the hope that it will be useful, @@ -13,8 +13,7 @@ # GNU General Public License for more details. # # You should have received a copy of the GNU General Public License -# along with this program; if not, write to the Free Software -# Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. +# along with this program. If not, see . # Some kernel core files have PID 0 (for the idle task), check that # GDB can handle such a core file.