Re: [PATCH 7/9] gdb: remove VALUE_NEXT_FRAME_ID, add value::next_frame_id

Simon Marchi
2023-12-22T17:06:17Z

On 2023-12-22 12:02, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:
>
> Simon> I'm not sure I understand, which function do you think should return a
> Simon> frame_info_ptr?
>
> value::next_frame_id (though also with a new name).
>
> value::fetch_lazy_register can just access the frame_id directly if it
> really needs to.
>
> I don't feel super strongly about this.

Ah ok I see. Well, even value::fetch_lazy_register does call
frame_find_by_id, so I guess it would make sense, it wouldn't be a
pessimization.

Simon