Re: [PATCH 7/9] gdb: remove VALUE_NEXT_FRAME_ID, add value::next_frame_id

Simon Marchi
2023-12-22T16:56:51Z

On 2023-12-22 11:51, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simon.marchi@efficios.com> writes:
>
> Simon> Remove VALUE_NEXT_FRAME_ID, replace it with a method on struct value. Set
> Simon> `m_location.reg.next_frame_id` directly from value::allocate_register_lazy,
> Simon> which is fine because allocate_register_lazy is a static creation
> Simon> function for struct value.
>
> I looks like every user except value::fetch_lazy_register actually
> immediatley calls find_frame_by_id with the result; so I wonder if this
> should just return a frame_info_ptr instead.

I'm not sure I understand, which function do you think should return a
frame_info_ptr?

Simon