From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id lu8XLkQc62XpDz4AWB0awg (envelope-from ) for ; Fri, 08 Mar 2024 09:10:12 -0500 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=oezILG1f; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id A598D1E0D2; Fri, 8 Mar 2024 09:10:12 -0500 (EST) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 5E6701E092 for ; Fri, 8 Mar 2024 09:10:10 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D1ABB3858415 for ; Fri, 8 Mar 2024 14:10:09 +0000 (GMT) Received: from omta036.useast.a.cloudfilter.net (omta036.useast.a.cloudfilter.net [44.202.169.35]) by sourceware.org (Postfix) with ESMTPS id 15CC83858D33 for ; Fri, 8 Mar 2024 14:09:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 15CC83858D33 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 15CC83858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709906991; cv=none; b=CUa/OwiejMh6q4+n9N7BDVC8s8W7v3xhkMXYnm/Xn/HZ3UxbQ3rkEhKylD9d4Hgyfnwn76dS+I/SXPZm6vft4dZXXHbhh4KRtfsqF65T5nYnEIBYWKqdTV9tdfe9edE9ig2CVw+S7x9BVJ+nAXN2ZKf/ZLilUJWlJRAgtskbie0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709906991; c=relaxed/simple; bh=TbnFqncrJcs8auuNz6Ue5p4wueSit3bEaG5HwIFbVcg=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=SNyiFCVt33gaRmaLxwKcOR9qTbj3W7Wmva/z+o1Wojm87x+yBMFMPLCSg/QvClrr2pES4n2Upg6GIQawGsDV4zVvqIxefYE26gkHPtllayJps2la7W/iDjsIcAHr6isnOTllALlm6BZ6AyGuL1Rqdg/7jOLTSR+/o4WRQFllq+o= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-5004a.ext.cloudfilter.net ([10.0.29.221]) by cmsmtp with ESMTPS id iYi8rQvtOuh6siauyrmaRn; Fri, 08 Mar 2024 14:09:48 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id iauxrSj81G7WliauxrDvRS; Fri, 08 Mar 2024 14:09:48 +0000 X-Authority-Analysis: v=2.4 cv=f/ZOBvyM c=1 sm=1 tr=0 ts=65eb1c2c a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=K6JAEmCyrfEA:10 a=Qbun_eYptAEA:10 a=zstS-IiYAAAA:8 a=CCpqsmhAAAAA:8 a=88Qs32-QR4MbQIzPJRYA:9 a=zgiPjhLxNE0A:10 a=4G6NA9xxw8l3yy4pmD5M:22 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Z8h/ThzEojyAL4WCoVlSfHkxUhk9Q2ohwgbIv+8Y5Cc=; b=oezILG1fK2ZyavqxNAIxStVIvk 3IjIRnA4o8GsfpfhvAlKmZEPKdjXOWjwGKhT9QM8uNqG4C0BgUGoSPdEU2x4hk73zGHQv6P3yNBnd UUrXGwsGeL36qFlhm2bG4D6yS; Received: from 97-122-82-115.hlrn.qwest.net ([97.122.82.115]:33986 helo=prentzel) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1riaux-0026wY-0s; Fri, 08 Mar 2024 07:09:47 -0700 From: Tom Tromey To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Avoid race when reading dwz file References: <20240125135129.977108-1-tom@tromey.com> X-Attribution: Tom Date: Fri, 08 Mar 2024 07:09:46 -0700 In-Reply-To: <20240125135129.977108-1-tom@tromey.com> (Tom Tromey's message of "Thu, 25 Jan 2024 06:51:29 -0700") Message-ID: <877ciczufp.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.82.115 X-Source-L: No X-Exim-ID: 1riaux-0026wY-0s X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-82-115.hlrn.qwest.net (prentzel) [97.122.82.115]:33986 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfM7SrehR53QVh2O4g92Va+FgxlBL7f8KbyFnpyYA/5gMnL13iczBYEpSW4aBAtFnikC569vqlSQFEEEIi+AJ18/9277CxQ6KDVFXhV4kuj0gm583BOCu bfKlQyoYCvnpj78SVRXoJU3Ukn5aa43dbGtccbl5GAtUP4/vsvLHRn1eAC2rRhVu4BuEL6P/O2/IcRCBZFrSKNfvdK3Q53Kttdk= X-Spam-Status: No, score=-3015.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org >>>>> "Tom" == Tom Tromey writes: Tom> PR gdb/31260 points out a race introduced by the background reading Tom> changes. If a given objfile is re-opened when it is already being Tom> read, dwarf2_initialize_objfile will call dwarf2_read_dwz_file again, Tom> causing the 'dwz_file' to be reset. Tom> This patch fixes the problem by arranging to open the dwz just once: Tom> when the dwarf2_per_bfd object is created. Tom> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31260 I'm checking this in. Tom