Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Thiago Jung Bauermann <thiago.bauermann@linaro.org>
To: Simon Marchi <simark@simark.ca>
Cc: gdb-patches@sourceware.org,  "Aktemur,
	Tankut Baris" <tankut.baris.aktemur@intel.com>,
	 "Maciej W. Rozycki" <macro@orcam.me.uk>
Subject: Re: [PATCH 1/2] GDB: frame: Make VALUEP argument optional in frame_register_unwind
Date: Fri, 10 Jan 2025 19:23:49 -0300	[thread overview]
Message-ID: <877c729ukq.fsf@linaro.org> (raw)
In-Reply-To: <27c5451c-bc77-480d-bd04-8c70e852c24e@simark.ca> (Simon Marchi's message of "Fri, 10 Jan 2025 12:02:44 -0500")


Hello Simon,

Simon Marchi <simark@simark.ca> writes:

> On 2025-01-10 11:43, Thiago Jung Bauermann wrote:
>> It already accepts a nullptr value and a couple of places were always
>> calling it that way, so make it possible to omit the argument entirely.
>> ---
>>  gdb/frame.c | 4 ++--
>>  gdb/frame.h | 4 ++--
>>  gdb/stack.c | 2 +-
>>  3 files changed, 5 insertions(+), 5 deletions(-)
>>
>
> Approved-By: Simon Marchi <simon.marchi@efficios.com>

Thanks! Pushed as commit 53a34429c96d.

--
Thiago

  reply	other threads:[~2025-01-10 22:24 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-10 16:43 [PATCH 0/2] Improvements to a few GDB frame unwind functions Thiago Jung Bauermann
2025-01-10 16:43 ` [PATCH 1/2] GDB: frame: Make VALUEP argument optional in frame_register_unwind Thiago Jung Bauermann
2025-01-10 17:02   ` Simon Marchi
2025-01-10 22:23     ` Thiago Jung Bauermann [this message]
2025-01-10 16:44 ` [PATCH 2/2] GDB: Use gdb::array_view for buffers used in register reading and unwinding Thiago Jung Bauermann
2025-01-10 17:45   ` Simon Marchi
2025-01-10 22:28     ` Thiago Jung Bauermann
2025-01-11 13:54       ` Tom de Vries
2025-01-11 15:46         ` Thiago Jung Bauermann
2025-01-11 16:01           ` Tom de Vries
2025-01-12  0:32             ` Thiago Jung Bauermann
2025-01-13 16:40               ` Tom de Vries

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877c729ukq.fsf@linaro.org \
    --to=thiago.bauermann@linaro.org \
    --cc=gdb-patches@sourceware.org \
    --cc=macro@orcam.me.uk \
    --cc=simark@simark.ca \
    --cc=tankut.baris.aktemur@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox