From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id RNsCK90ZiWd1LREAWB0awg (envelope-from ) for ; Thu, 16 Jan 2025 09:38:21 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=dSppx7AG; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id A07431E100; Thu, 16 Jan 2025 09:38:21 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 6A7591E08E for ; Thu, 16 Jan 2025 09:38:20 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E2815384F4BA for ; Thu, 16 Jan 2025 14:38:19 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E2815384F4BA Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=dSppx7AG Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 7BC25385023A for ; Thu, 16 Jan 2025 14:37:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7BC25385023A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7BC25385023A Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1737038260; cv=none; b=UpjiLvGj5gUWU/nrbhVFo9ypvfx/jmONjnsm4v0STwo/n5tqLRXt/54Pcr1axL8zE+wyuliyRql5XLswey0OMBxv+DDaGoGV1ouaRmYqq7tYoLJ0Ai6gsNuNUHzDVk33fHuCsLt+5TFtP7mD8MP+h6lXKm9Pv9GuJp03ll69q2Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1737038260; c=relaxed/simple; bh=Y4wpPK8+Mn/DhtOQ+P0zKpy7tqqqzH2qrWedftkTD1A=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=KQ2Kq0C8bWhrOyhyS8fmCAB//KPfsYnJawGWiyHSvPCzzgNd7o/9uhfPyUGnyiZy863zy79Fdm6RUHDkXTaFMVmF4oTz2Cr76+Drw5Fy0l/jaWviikmKQ+R/DiO8Rsjrv5PueSJSgW/HbQRyeAcTUcrCbVmFsxiPUU+ZPPxvzPw= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7BC25385023A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1737038260; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PDjYqNqoQufu5uhPMvxhkXqTzJvvvjM4kyP5POGdwB0=; b=dSppx7AGsT7Ey1hKUbObR7kqE0rpOaonGGNr6Esez7PJf7rwyYdytQ9tnPf5nvXyZDXy7d yu1TiDv8FDsQ0OXBdC0PPivIbuS8BeP5OzdKIEnYvxrmKa8YslT12KyN07hCO8xCL3tpMH +1JM1IC4tEbygZ/ByXMFTn/sKLz31yE= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-190-uDdLSjQtP76xh4AKt0WAwQ-1; Thu, 16 Jan 2025 09:37:39 -0500 X-MC-Unique: uDdLSjQtP76xh4AKt0WAwQ-1 X-Mimecast-MFC-AGG-ID: uDdLSjQtP76xh4AKt0WAwQ Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-38a684a0971so468105f8f.2 for ; Thu, 16 Jan 2025 06:37:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737038257; x=1737643057; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=PDjYqNqoQufu5uhPMvxhkXqTzJvvvjM4kyP5POGdwB0=; b=FzPS9WLIe7YRfvlMv28VcdaZO4npcSDZX96J+3b9kYPuv6CsCjdvG1IWhqM7J16nsP of7IQxQF3MN6wpx+wqMFy4G0YgXTqXjRFH12egzu0gWrlkGCQrf+oJlb4oXUuGfZy3xF rC9q8auUL9VDSf15Xu9at0CmpW/BSm/fPGPpn8BKNg7XcNwMFuv3GZQrC5Q12U7+3aEY n1X0JsBpw7N+zp2br+l10DlC9NAJ9crxyrDotAp+X3qyY2SNR/Hy6OEmfb4rkWnvtaRL 4zQwzIi/4TCUqDElSH7/LAHitHZNifHe0CEd2H/UCOA69NBJjmbky/M1FzeX4JzhR2Es /y5g== X-Forwarded-Encrypted: i=1; AJvYcCXvA6Mp9OXvKQ9w/wMnIcMN+jYHTDQr5y/FulkUilX7Opz1VYD2TjvBtVtDzLAWO4sx5zsVMnak/rxhOQ==@sourceware.org X-Gm-Message-State: AOJu0YzrNBWJDiCMNs20frAbGfgOA3T0TEzYMiYFz6fkppLfUv38CgX/ B0H0HXqarmBH6DTmRp6Ad+cRpWDejmYN/z7PoDynHw8P6VJTj9+OUuggtEbwliweiV4BgBX9Ntq /dM2FcLklGpsgXbWWxYPcEv3pSoSyi/ZITfBNpJSxAcFUWC8TQJQtYvUBJ8U= X-Gm-Gg: ASbGnctv+UxUn5dT2K9bdTSKwd6YcsrK4v4GBsa7utNYuRkQYpRlVwhYZsxeNYn8AZN mhTpg8z3718vBokIlgbgFaL7UgSdhIJo3+BmgkeDc+XojfiZJkDcICZv0KyypT6i3Vk3Ein57xl w2/WKXRbuH31AiJAgf4Ll7zzzax3ohWZ0fely9bJTnZEWYQT73/tpc2e2msutvup3+Xvf+tGSl8 bsd3O1v1NwiQ2o9jmj76BpMoDYBmGij41VwYzc0EEh+yk6hpACwARfT5tqpN9hAZl8tc3PrDyxB Bh+fQQ== X-Received: by 2002:a5d:64ee:0:b0:386:459e:e138 with SMTP id ffacd0b85a97d-38a87337003mr27379185f8f.36.1737038256712; Thu, 16 Jan 2025 06:37:36 -0800 (PST) X-Google-Smtp-Source: AGHT+IEOWubdsl/kBBNLdgaT6gmq5CJhospAQNv32FSBGBMIhDdPquIEfkRBp6Ym6kK64aOFN2Usqw== X-Received: by 2002:a5d:64ee:0:b0:386:459e:e138 with SMTP id ffacd0b85a97d-38a87337003mr27379156f8f.36.1737038256246; Thu, 16 Jan 2025 06:37:36 -0800 (PST) Received: from localhost (44.226.159.143.dyn.plus.net. [143.159.226.44]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38bf327e06asm15960f8f.95.2025.01.16.06.37.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jan 2025 06:37:35 -0800 (PST) From: Andrew Burgess To: Guinevere Larsen , gdb-patches@sourceware.org Cc: Guinevere Larsen , Jan Kratochvil , Thiago Jung Bauermann Subject: Re: [PATCH v8 5/5] gdb/testsuite: Test for a backtrace through object without debuginfo In-Reply-To: <20241210195115.3046370-6-guinevere@redhat.com> References: <20241210195115.3046370-1-guinevere@redhat.com> <20241210195115.3046370-6-guinevere@redhat.com> Date: Thu, 16 Jan 2025 14:37:34 +0000 Message-ID: <877c6uq0y9.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: SWZZf1FoFqGF_aiWxM56pl_YFUAEWotLHK7kISjkg7E_1737038257 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Guinevere Larsen writes: > Fedora has been carrying this test since back in the Project Archer > days. A change back then caused GDB to stop being able to backtrace when > only some of the object files had debug information. Even though the > changed code never seems to have made its way into the main GDB project, > I think it makes sense to bring the test along to ensure something like > this doesn't pass unnoticed. > > Co-Authored-By: Jan Kratochvil > Reviewed-by: Thiago Jung Bauermann > --- > .../backtrace-through-cu-nodebug-caller.c | 28 ++++++ > .../backtrace-through-cu-nodebug-main.c | 32 +++++++ > .../gdb.base/backtrace-through-cu-nodebug.exp | 95 +++++++++++++++++++ > 3 files changed, 155 insertions(+) > create mode 100644 gdb/testsuite/gdb.base/backtrace-through-cu-nodebug-caller.c > create mode 100644 gdb/testsuite/gdb.base/backtrace-through-cu-nodebug-main.c > create mode 100644 gdb/testsuite/gdb.base/backtrace-through-cu-nodebug.exp > > diff --git a/gdb/testsuite/gdb.base/backtrace-through-cu-nodebug-caller.c b/gdb/testsuite/gdb.base/backtrace-through-cu-nodebug-caller.c > new file mode 100644 > index 00000000000..3a63d72a468 > --- /dev/null > +++ b/gdb/testsuite/gdb.base/backtrace-through-cu-nodebug-caller.c > @@ -0,0 +1,28 @@ > +/* This testcase is part of GDB, the GNU debugger. > + > + Copyright 2005-2024 Free Software Foundation, Inc. > + > + This program is free software; you can redistribute it and/or modify > + it under the terms of the GNU General Public License as published by > + the Free Software Foundation; either version 3 of the License, or > + (at your option) any later version. > + > + This program is distributed in the hope that it will be useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + GNU General Public License for more details. > + > + You should have received a copy of the GNU General Public License > + along with this program. If not, see . */ > + > +typedef int (*callback_t) (void); > + > +int > +caller (callback_t callback) > +{ > + /* Ensure some frame content to push away the return address. */ > + volatile const long one = 1; > + > + /* Modify the return value to prevent any tail-call optimization. */ > + return (*callback) () - one; > +} > diff --git a/gdb/testsuite/gdb.base/backtrace-through-cu-nodebug-main.c b/gdb/testsuite/gdb.base/backtrace-through-cu-nodebug-main.c > new file mode 100644 > index 00000000000..3e7ac57a166 > --- /dev/null > +++ b/gdb/testsuite/gdb.base/backtrace-through-cu-nodebug-main.c > @@ -0,0 +1,32 @@ > +/* This testcase is part of GDB, the GNU debugger. > + > + Copyright 2005-2024 Free Software Foundation, Inc. > + > + This program is free software; you can redistribute it and/or modify > + it under the terms of the GNU General Public License as published by > + the Free Software Foundation; either version 3 of the License, or > + (at your option) any later version. > + > + This program is distributed in the hope that it will be useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + GNU General Public License for more details. > + > + You should have received a copy of the GNU General Public License > + along with this program. If not, see . */ > + > +typedef int (*callback_t) (void); > + > +extern int caller (callback_t callback); > + > +int > +callback (void) > +{ > + return 1; > +} > + > +int > +main (void) > +{ > + return caller (callback); > +} > diff --git a/gdb/testsuite/gdb.base/backtrace-through-cu-nodebug.exp b/gdb/testsuite/gdb.base/backtrace-through-cu-nodebug.exp > new file mode 100644 > index 00000000000..c0940b406a8 > --- /dev/null > +++ b/gdb/testsuite/gdb.base/backtrace-through-cu-nodebug.exp > @@ -0,0 +1,95 @@ > +# Copyright 2010-2024 Free Software Foundation, Inc. Remember to update the copyright year throughout. > + > +# This program is free software; you can redistribute it and/or modify > +# it under the terms of the GNU General Public License as published by > +# the Free Software Foundation; either version 3 of the License, or > +# (at your option) any later version. > +# > +# This program is distributed in the hope that it will be useful, > +# but WITHOUT ANY WARRANTY; without even the implied warranty of > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > +# GNU General Public License for more details. > +# > +# You should have received a copy of the GNU General Public License > +# along with this program. If not, see . > + > +# Test that GDB can generate accurate backtraces even if some of the stack > +# trace goes through a function with no debug information. > + > +standard_testfile -caller.c -main.c > +set objmainfile ${testfile}-main.o > +set objcallerfile ${testfile}-caller.o > + > +# recompile the inferior with or without CFI information, then run the > +# inferior until the point where the important test starts > +# returns TRUE on an ERROR. Needs converting to two sentences ('.' after 'starts'). Plus capital 'R' for each sentence. I wonder if it would be better to return TRUE on success, and FALSE on error, because .... see below ... > +proc prepare_test {has_cfi} { > + global srcdir subdir srcfile srcfile2 objmainfile objcallerfile binfile > + if {$has_cfi} { > + set extension "cfi" > + if {[gdb_compile "${srcdir}/${subdir}/${srcfile}" \ > + "${srcdir}/${subdir}/${objcallerfile}" \ > + object [list {additional_flags=-fomit-frame-pointer \ > + -funwind-tables -fasynchronous-unwind-tables}]] != "" } { > + untested "couldn't compile with cfi" > + return true > + } > + } else { > + set extension "no-cfi" > + if {[gdb_compile "${srcdir}/${subdir}/${srcfile}" \ > + "${srcdir}/${subdir}/${objcallerfile}" \ > + object [list {additional_flags=-fomit-frame-pointer \ > + -fno-unwind-tables \ > + -fno-asynchronous-unwind-tables}]] != "" } { > + untested "couldn't compile without cfi" > + return true > + } > + } > + if {[gdb_compile [list "${srcdir}/${subdir}/${objmainfile}" \ > + "${srcdir}/${subdir}/${objcallerfile}"] \ > + "${binfile}-${extension}" binfile {}] != ""} { > + untested "couldn't link object files" > + return true > + } > + > + clean_restart "$binfile-${extension}" > + > + with_test_prefix "${extension}" { > + > + if ![runto callback] then { > + fail "has_cfi=$has_cfi: Can't run to callback" > + return true > + } > + gdb_test_no_output "maint frame-unwinder disable ARCH" > + return false > + } > +} > + > +if {[gdb_compile "${srcdir}/${subdir}/${srcfile2}" \ > + "${srcdir}/${subdir}/${objmainfile}" \ > + object {debug}] != "" } { > + untested "couldn't compile main file" > + return > +} > + > +if { [prepare_test false] } { > + untested ${testfile}.exp > +} else { > + gdb_test "bt" "Required frame unwinder may have been disabled.*" \ > + "verify unwind fail without CFI" > +} When something goes wrong with the prepare_test call we've already emitted an 'untested' or 'fail' message, thus I think we can just write: if { [prepare_test false] } { ... perform the test ... } Of course, this assumes that the true/false return value for prepare_test have been switched. Currently you'd write: if { ![prepare_test false] } { ... perform the test ... } which just seems weird. Also, the test here says "verify unwind fail without CFI". And we _do_ check for the error message about disabled unwinders. But if the `bt` worked this test would still pass just fine. We should probably be checking that we only print frame #0. Something like: gdb_test "bt" \ [multi_line \ "\[^\r\n\]+Required frame unwinder may have been disabled, \[^\r\n\]+" \ "#0\\s+callback \\(\\) \[^\r\n\]+"] \ "verify unwind fail without CFI" should do the job I think. > + > +if { [prepare_test true] } { > + untested ${testfile}.exp > +} else { Same suggestion here about avoiding the extra 'untested' call. > + if { [istarget "arm*-*-*"] } { > + setup_kfail backtrace/31950 *-*-* > + } > + set text {[^\r\n]+} > + # #0 callback () at ... > + # #1 0x00000000004004e9 in caller () > + # #2 0x00000000004004cd in main () at ... > + gdb_test "bt" \ > + "#0 +callback $text\r\n#1 $text in caller $text\r\n#2 $text in main $text" \ > + "verify unwinding works for CFI without DIEs" The test name here seems weird. Maybe: 'verify unwinding works for CUs without CFI' would be better? OK with these fixes. Approved-By: Andrew Burgess Thanks, Andrew > +} > -- > 2.47.0