From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id xC69BoC8MGhUCjAAWB0awg (envelope-from ) for ; Fri, 23 May 2025 14:20:48 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=RnzybG1q; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 0758E1E11C; Fri, 23 May 2025 14:20:48 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-10.1 required=5.0 tests=ARC_SIGNED,ARC_VALID, BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED, RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 738CF1E102 for ; Fri, 23 May 2025 14:20:47 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DAB8A385608B for ; Fri, 23 May 2025 18:20:46 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DAB8A385608B Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=RnzybG1q Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 58FEF3858C2A for ; Fri, 23 May 2025 18:20:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 58FEF3858C2A Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 58FEF3858C2A Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1748024414; cv=none; b=xFp50eMyakHb/wiDQkrwgd7NVFl25w2UnBkzA5kTOB3H1torf93QqYWeKYcx5846/XU39ehYFQ6+MgnE4Nh34Tzebm3BFrNn0l8Rgi5wED6Ub7QVDeS2fUjTzzgauiPDloAlHxZTxPhmEuGSb8DZwmAi6D9DImbzXjYXNc/Hy4k= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1748024414; c=relaxed/simple; bh=crKIrO2oxe52RkekijvL7Y0nkcbcDjO2/NQIEL9NVy4=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=MoVzWnq7hZjOLT7qvRIgWYtdZHvJrLixF2SFtz/YreHGsXFsmXrgHf/E8Wn0FuzmZ6QIAsl2/0kv0uPXG9qsC70yqKxcdiZnNhhEGj+pVpYyfZPNQW/Mp0/tz55xgZRkXWcOOndrRYRpa41LVrn/1dZ8IeBAvbYecHhhK5y2PjU= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 58FEF3858C2A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1748024414; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Cx7QNsdaY2DVL7puTJUbbox8HHocFnx0U1bAQjTqkMA=; b=RnzybG1qRw6TfivHBEZ53/o+hNLIEOAJmryaMcr9d/M7f7l9SGfxrXWOlf00vC5OVn6P6F TbpfV/Cz+pa0EZtHCIPkfuGPSb+Jkzsxj63uwpRcM7+potSIWOBK+j/ZFM1zUuikUT50uf mvR9t9sBxzDreERJgRFaTyfhmUETdAs= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-413-zWZg-GmNMWeYglP19wiPNQ-1; Fri, 23 May 2025 14:20:12 -0400 X-MC-Unique: zWZg-GmNMWeYglP19wiPNQ-1 X-Mimecast-MFC-AGG-ID: zWZg-GmNMWeYglP19wiPNQ_1748024411 Received: by mail-ej1-f69.google.com with SMTP id a640c23a62f3a-acbbb0009aeso7646266b.1 for ; Fri, 23 May 2025 11:20:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748024411; x=1748629211; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Cx7QNsdaY2DVL7puTJUbbox8HHocFnx0U1bAQjTqkMA=; b=qg6bfc3CjZgNTLNzgb402kNZsmBcdeOSK9G5Nkwqx28Ab9JLS2IQgsVyHN00WfXYwb DVN9Y9Mi9F7XBuMb3XmsE0bhDs2FO0gr/Be61xDck/QRkO1pd+klv8CmvzYs3nkjg16t gvXba8qcK1ajA48j0ZSkaMOwSYh9Q0ef9jQHeVVrV6BABtOQwDQ5Ony40YDXUFtMX2kv 85MZPM5k8Zz61XmLVp71mBYAyD9xConqGXIBtniqFTqoxu+j0dbEUS2S5qg1Un+SOupJ j6yQIe0RbTbcwSMJB94h9YLzaReBZklYfBgiRcAjZsPWqKlsBSyLCjv3BnCC6I5kok0A Uy9Q== X-Forwarded-Encrypted: i=1; AJvYcCWrOPZ+91JneIegnEjUnR4HuelFYIiBcBsYCkXlSTo1D9pRFFFz8Uh3prrxnRwYT5RSjkT7s8VkhcxLPA==@sourceware.org X-Gm-Message-State: AOJu0Yz8PEHSN1oDrYwUA5s9DgAYVlwctU8++dzweTD5vZx+mp/ZMGie 7RGGPZwdIsZBYNsuuWmHSvqevzOz/ijUrEYqWZJd8BBhG5O/UGvoqwSj4R3pRJxp+W5XSp14v3X tWLiMon2Vr1jag9vJSUKONxQNOYMboN5VMeUwaIUuxrtDkR8uidcPA2xE9LGxJn/NgJjEL14= X-Gm-Gg: ASbGncui227tPdeTgUXo7jkO6nTHxUfPVOMnUwkzfqMmcWJeYknyxF9hyi1fCbIMt1e O74s7mXtScHlOX7NMtuy3mgObjkreWUvmIf3NO3F1oZXHV2cP5xRrNG+cA6kEaaSfrc9BOFN/KH 7IK4DRb0OmVKsM1zE+rjcEHyaviogx1oRqMKbRqIaf92r+SGKzD6WPy1ursZL2Po4cYtyOZr0+G t2yN3GA2qMo5u2C3OHsEtTDsSwo/5wb5kNrgh9SO2cvAWS0NEvYKH3GIa6JL5qow6HZLh3tkinj DxmEAZxWwK7obMozbc5Xn9jcyMz3upPeP8nD X-Received: by 2002:a17:907:72c1:b0:ad5:bf7e:dcb2 with SMTP id a640c23a62f3a-ad85b1de6b5mr18218266b.41.1748024410832; Fri, 23 May 2025 11:20:10 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEnZRh1QMA8aP4Lmu3TBwMbL7xeX7HEsMcBd0d9Y/2VqEbfHjbFSam2OUEGBBsvk1GL1d5YDg== X-Received: by 2002:a17:907:72c1:b0:ad5:bf7e:dcb2 with SMTP id a640c23a62f3a-ad85b1de6b5mr18216066b.41.1748024410384; Fri, 23 May 2025 11:20:10 -0700 (PDT) Received: from localhost (92.40.184.162.threembb.co.uk. [92.40.184.162]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ad52d44205asm1278707266b.100.2025.05.23.11.20.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 May 2025 11:20:09 -0700 (PDT) From: Andrew Burgess To: Fabian Kilger , gdb-patches@sourceware.org Cc: Fabian Kilger Subject: Re: [PATCH 2/2][PR GDB/32956] gdb: query inferior's filesystem for build-id debug files In-Reply-To: <20250511150113.3163767-3-kilger@sec.in.tum.de> References: <20250511150113.3163767-1-kilger@sec.in.tum.de> <20250511150113.3163767-3-kilger@sec.in.tum.de> Date: Fri, 23 May 2025 19:20:08 +0100 Message-ID: <877c27i3zb.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: VYioPUtaHM4WRknN1FYkptyk_4eW13S2zDWiWTQYIvg_1748024411 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Fabian Kilger writes: > This fixes a bug related to build-id files with linux namespaces. > Specifically, we expect the debug files to be present inside the container, > thus the container filesystem should be queried if the program is running > inside one. You should add a bug link to the end of this commit message, like: Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=32956 With that added, for this patch: Approved-By: Andrew Burgess You are welcome to merge this ahead of patch #1 if you want, as they are related, but don't depend on each other. Thanks, Andrew > > --- > gdb/build-id.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/gdb/build-id.c b/gdb/build-id.c > index 43a80dd3978..abbd65a7c12 100644 > --- a/gdb/build-id.c > +++ b/gdb/build-id.c > @@ -29,6 +29,7 @@ > #include "gdbsupport/scoped_fd.h" > #include "debuginfod-support.h" > #include "extension.h" > +#include "inferior.h" > > /* See build-id.h. */ > > @@ -128,7 +129,8 @@ build_id_to_debug_bfd_1 (const std::string &original_link, > if (supports_target_stat != TRIBOOL_FALSE) > { > struct stat sb; > - int res = target_fileio_stat (nullptr, link_on_target, &sb, > + int res = target_fileio_stat (current_inferior (), > + link_on_target, &sb, > &target_errno); > > if (res != 0 && target_errno != FILEIO_ENOSYS) > @@ -157,7 +159,7 @@ build_id_to_debug_bfd_1 (const std::string &original_link, > the path doesn't exist, but we just assume that anything > other than EINVAL indicates the path doesn't exist. */ > std::optional link_target > - = target_fileio_readlink (nullptr, link_on_target, > + = target_fileio_readlink (current_inferior (), link_on_target, > &target_errno); > if (link_target.has_value () > || target_errno == FILEIO_EINVAL) > -- > 2.49.0