From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id qP/lLC1hN2jgOTgAWB0awg (envelope-from ) for ; Wed, 28 May 2025 15:17:01 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=KxjrR0TO; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 9F3ED1E11C; Wed, 28 May 2025 15:17:01 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-8.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 16CC91E102 for ; Wed, 28 May 2025 15:17:01 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A2B8738560A3 for ; Wed, 28 May 2025 19:17:00 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A2B8738560A3 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=KxjrR0TO Received: from omta040.useast.a.cloudfilter.net (omta040.useast.a.cloudfilter.net [44.202.169.39]) by sourceware.org (Postfix) with ESMTPS id 179563856DFA for ; Wed, 28 May 2025 19:16:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 179563856DFA Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 179563856DFA Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1748459792; cv=none; b=GrGElaefLNgNdPrSTEkDYEn95tkFXnebIHPgGb9mgIY7af4qCge5i8elqyt5PW6iPaJQmbORlLZ93Pz4Z0QQ3GV9lzHFO5YxMEsvHSt4o3zIndts6zM+u8eSUHu0BCtwe183fMxTyTwbvbWAKop5is14rDAUbp2PM6Sj1Q99ICY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1748459792; c=relaxed/simple; bh=lB6eKY8ijNhKHiSP6g5YzKYgHiYF+ca+XkBzK3gLZuk=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=hvnHRzL9bjzox+VpMMnIds2Ju1AdIujySvjqCF0mc7JBiZX/iBs6Vs7M2frLSEW8sJO2sUPydYCmIj4HwaBB40Tnct8yTPZfeRPHsHHD4fEqpwE5HwiV5ylEsvUYQ7FZBoAomFx6b2MdSLpF2VK4Xr9KVMTMhlhh21C0PtZRh60= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 179563856DFA Received: from eig-obgw-6010a.ext.cloudfilter.net ([10.0.30.248]) by cmsmtp with ESMTPS id KBhluN31YVkcRKMGNud3TJ; Wed, 28 May 2025 19:16:31 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id KMGMudsB7hHAkKMGNuVzYp; Wed, 28 May 2025 19:16:31 +0000 X-Authority-Analysis: v=2.4 cv=YsIJRZYX c=1 sm=1 tr=0 ts=6837610f a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dt9VzEwgFbYA:10 a=ItBw4LHWJt0A:10 a=T_Alst9gAAAA:8 a=zstS-IiYAAAA:8 a=3CrXl5UuAvYwb1ckraAA:9 a=DvZ5ixILWSEuw56YIEpp:22 a=4G6NA9xxw8l3yy4pmD5M:22 a=VS4QxaUSPT0UtbFnIvSC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=SrtMkcI4dsAQnEJfklP2f9Y/yrTy8R9QXdyIw7LI9c8=; b=KxjrR0TOnkRot02hfkkiisBYOC vIPEiHjwbAXWmT0Ee+0dhNGXzaPMqqJNfPrwcVlaN9kmRXc46W/C677/iO7DZonkhWRh1yVcFOopI BFjVWKTNWsGckFf8MzSJPN5Mm; Received: from 97-118-46-156.hlrn.qwest.net ([97.118.46.156]:54124 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.1) (envelope-from ) id 1uKMGM-00000002WMG-0QQN; Wed, 28 May 2025 13:16:30 -0600 From: Tom Tromey To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2 14/47] Windows gdb: Simplify windows_nat_target::wait In-Reply-To: <20250519132308.3553663-15-pedro@palves.net> (Pedro Alves's message of "Mon, 19 May 2025 14:22:35 +0100") References: <20250519132308.3553663-1-pedro@palves.net> <20250519132308.3553663-15-pedro@palves.net> X-Attribution: Tom Date: Wed, 28 May 2025 13:16:28 -0600 Message-ID: <877c20h7g3.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.118.46.156 X-Source-L: No X-Exim-ID: 1uKMGM-00000002WMG-0QQN X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-118-46-156.hlrn.qwest.net (bapiya) [97.118.46.156]:54124 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfHMtReiXTzrGCgZJsPev4CsSHGOSrcwR64UiCQhaZkzgCa4DQNQ09AjHF13Du6zqnkC6XYiL6TgFFWATwrSRqUpQtH5XA1aMODRi7V8PaziOjg+u/aCe utf0mUdB8i7BxRK/ToW+4qfowxjPNIJd61MLZMw6NRnA/CnI2xfWq2i0hPxB2RNgt5bs/MLBQ1u5w+cwx6ckZU5hVoYyODcHifs= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Pedro" == Pedro Alves writes: Pedro> This patch changes things a bit so that the code is more obvious: Pedro> - look at the status kind, instead of ptid_t. Pedro> - add an explicit early return case for no-event. Pedro> - add an explicit case for TARGET_WAITKIND_SPURIOUS. Pedro> - with those, we no longer need to handle the case of find_thread not Pedro> finding a thread, so we can drop one indentation level. Thanks for cleaning this up. I think this is ok. It's hard to be really sure in this area, I feel like I've had multiple rounds of changes here in the past. Approved-By: Tom Tromey Tom