From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id KUjNA9t4+mip4QQAWB0awg (envelope-from ) for ; Thu, 23 Oct 2025 14:50:03 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=ZpQr4c0W; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 09B9E1E0BC; Thu, 23 Oct 2025 14:50:03 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 4A6441E057 for ; Thu, 23 Oct 2025 14:50:01 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D87473858019 for ; Thu, 23 Oct 2025 18:50:00 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D87473858019 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=ZpQr4c0W Received: from omta40.uswest2.a.cloudfilter.net (omta40.uswest2.a.cloudfilter.net [35.89.44.39]) by sourceware.org (Postfix) with ESMTPS id 8FACE3858419 for ; Thu, 23 Oct 2025 18:49:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8FACE3858419 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8FACE3858419 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1761245362; cv=none; b=I4X/mtaXa2st65ZH2VZrfgxxlodLW2i+4u88wgJ2i1pVK1fwKiTKefxf2/DF3zGgQGdwvFuSsPsQwa8Tz6K4Wzt08zSlNqPf1og91ulQJ+Ec0PAUcvLUcohhLQd34vvkdAOsya6cdjecpp6hXLF9clHynQf1eTK2xpfYSioMvH0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1761245362; c=relaxed/simple; bh=tELzTOLRFfk/wW3uXuYxNeqgAZBziH4+EvJ4asFazFE=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=rpQn34/OFB44FIbjiUNOJaRQC/6br+LQq9gABB1uGe+qh2lD8IryuO3liNXiKe6MJwHZRe4DLDnYdoUtoF4Ma7mhVIH50WUcZ4SCrt7ymAfQLFG+2CkGSNA4DQHCQq18h28cY+R8VGiHs0qek56l4usjzSAxfRoLqWg3vbOF/E0= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8FACE3858419 Received: from eig-obgw-5003b.ext.cloudfilter.net ([10.0.29.155]) by cmsmtp with ESMTPS id BZzVvdbcMaPqLC0NFvLlI3; Thu, 23 Oct 2025 18:49:21 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id C0N8v2RC0uWNOC0N9vccRx; Thu, 23 Oct 2025 18:49:15 +0000 X-Authority-Analysis: v=2.4 cv=N+gpF39B c=1 sm=1 tr=0 ts=68fa78b1 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=x6icFKpwvdMA:10 a=ItBw4LHWJt0A:10 a=YeGuSiPmN1D9Y7Ohy40A:9 a=VS4QxaUSPT0UtbFnIvSC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=tELzTOLRFfk/wW3uXuYxNeqgAZBziH4+EvJ4asFazFE=; b=ZpQr4c0W50r2kpqFXvuQ5/ufHM NQsY9Al+b71CaIb9j2ZmNCsjrdVq4XSIT3fXUOyrkQcDJDMJBCeAzquDFxb3E1EOw8Kc71aOQhYAG AZAOAcP5wCSH5KnxBLiXDLrBF; Received: from 97-122-110-68.hlrn.qwest.net ([97.122.110.68]:34384 helo=prentzel) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vC0N8-00000004Hve-1fP1; Thu, 23 Oct 2025 12:49:14 -0600 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 1/2] Two bug fixes in mdict_free In-Reply-To: <9266c5a7-bf78-4c48-af1a-56a362093d11@simark.ca> (Simon Marchi's message of "Thu, 23 Oct 2025 14:32:18 -0400") References: <20251023-mdict-free-v1-0-ad02b2bdd549@tromey.com> <20251023-mdict-free-v1-1-ad02b2bdd549@tromey.com> <4c83ffce-598b-4712-9b98-45728d52b4d0@simark.ca> <9266c5a7-bf78-4c48-af1a-56a362093d11@simark.ca> X-Attribution: Tom Date: Thu, 23 Oct 2025 12:49:12 -0600 Message-ID: <877bwlbgif.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.110.68 X-Source-L: No X-Exim-ID: 1vC0N8-00000004Hve-1fP1 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-110-68.hlrn.qwest.net (prentzel) [97.122.110.68]:34384 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfAJ25nCFlRqrIwSjbOjeTUV+7VcNYiMpP5vYhfiXOvQDDogC+heoHqLuJMcu/MmfGeCXsKLflRLmhT1Owhon0/9EXFJEyPD3gsefFEPCvvLwtESxRoc6 kXX6yYoUWShpaHHvPyo0thf9zY2AP3XttxH8y6y70IvCIFIS7BPGtIi6xxZ5z03PeE+e/z7pYrLFbaCpokSGkA96JZ7q3QJ0VxQ= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >> I think you could just remove dict_vector::type and use >> multidictionary::type at the single spot where dict_vector::type is >> still used. Simon> Btw, your change LGTM with or without my suggestion. I made the change. Tom