From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id W8giE+jADGn5YyYAWB0awg (envelope-from ) for ; Thu, 06 Nov 2025 10:38:16 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=hAE+ukWm; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 3D21E1E0BC; Thu, 06 Nov 2025 10:38:16 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=unavailable autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B01FF1E04C for ; Thu, 06 Nov 2025 10:38:15 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 50095385DC0A for ; Thu, 6 Nov 2025 15:38:15 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 50095385DC0A Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=hAE+ukWm Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 62843385482F for ; Thu, 6 Nov 2025 11:06:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 62843385482F Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 62843385482F Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1762427191; cv=none; b=LppvXtyvoOIYun/T3WtoPwGcK5upYylqrtChq8M7R7RtbjpKPWx3Mgeklijfld0OrLJ0M5Xi53mZhhmHpmx7r7ITeRyIiAjZ4kbC6KtxX36AvVljiDppaP4Vv9PCDv5Ycfe+1xUsedw4nJNBUWuDIv+o62tuDg5zppMsk0eHaew= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1762427191; c=relaxed/simple; bh=b3FLRL6bDnDCgvg9bRjMVaUaKya7eOpLAxlDZ2wc99w=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=ito1PGNpqotHYNpij0GKzhOiQH75LD3M/Rj+hWkylo0K3JNEXQDg6WydlaYEeE+ics19Np4mwgw4h6sLEJXIgVCttS6GzJkRbjcWYWMOIMBnZpys4T/NAmagERXcNNrJ3dQzCvviLxjgCkPx1GnV3i2nilCdj2MB1Dxwl7lklYA= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 62843385482F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1762427191; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jnMK+VF3ngLvLX9TmZAvl0cnFALihSo2Rk13vxhAJ+M=; b=hAE+ukWmwrhH8GVWTVliJHYx0HO6FVxP8GTk/7Jc5qaMzNWcUMvpwvtpXz1Q7toP2lV0YQ vS200zH9iLa7U7FEQOE9XW7z0EUVIu1AwUau1R/jdWcfB4pQeYJDlc+cBmrTwoxkwIG7VC Yb6aTzo0e+FsueuaXgMubqXWeB7H9Bc= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-140-VeIHlsjkOvSqvbHMmYXb0Q-1; Thu, 06 Nov 2025 06:06:30 -0500 X-MC-Unique: VeIHlsjkOvSqvbHMmYXb0Q-1 X-Mimecast-MFC-AGG-ID: VeIHlsjkOvSqvbHMmYXb0Q_1762427189 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-477212937eeso4994485e9.2 for ; Thu, 06 Nov 2025 03:06:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762427188; x=1763031988; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LsnnDF+4UU3RQKitZTUfwr+uopq7EJlc31XTmZ1PhhM=; b=TtWOkpRjrBcm+bvYMgioDioZMxEAF0IvKexl4GYSV0+SvIWsxSVmbN620NF/pMbqKz MTbeml5H9XLLp7NOGju8wzZvZsAdyDM9wma63v8M0dqlv07i//YZ6fj2b7RrQixDuDx2 vbkjhZxeyESalaxlaW2WbPAQPtOYc/K4V867aqug2yNAmi/k+jMLBAL57bY0nyvmiBmz 6xPbU6M0sWiDoBJzzd2YYG4XbEkwRfMHrYDCV9T+OkoCZIZ+AGRgijp9N5Z9Lgo/+6sl ZKOJAd6CHJNlNoPH+oe+5fljm8S8Fz8GfNlS9H0X0vhKT/xgr4RJNovE0Ll/QeCMaeOQ kzjQ== X-Forwarded-Encrypted: i=1; AJvYcCX5Ri9sIfW3NDdx7+8TJpGO62aD6M81cm0jITOts4Olh+8kwByG64QVEBLIbjhx8tihZrPFOz5W1vldZQ==@sourceware.org X-Gm-Message-State: AOJu0YxOPQZlS+7yPRSYSi4wzP1hZ3jMH4csUhDullegox2Vhi8a3sWc CpZD/5GEmc4dg2pn/bff2trhKpazCN+fvIKPAnnkxNoZIchd0pO0Ss4Oe4t7jDFsZhrPm7BmIOM yyPzkxozt2LTltNHYiO4rJYz2zao53Wd+KgbA8jNzlt7yt1WMDWaDGFSq/pNXSnEaYBlSluA= X-Gm-Gg: ASbGncvwPCD/m7gZNG8H5yuXSFVorgcTT8hFhjYjjmGOWfRQqaOSArR6nC72wvxmQ4d csk0c/PXU1w2IhFunR177XwsFzDCDB/wxp93DXSg/F03cPgqfZRKNzZV2yLcPDxu4wbRS0yKHVm eJYW4kDJds0WF8pN/fIYp5sTllFjk+55VeueQF92x6HKoRY0/Jo4FWEITu8K8IG7IFDGUYNQWr3 t6c/Jul/dWwOUvT6nCtIRqstmnsrG3xN3adgouV+kCfpC2JJiKmsyyNhRh3+v5vAhYO9m2c9RrV NcA8qM3z6ND7BihX/HmaSyoW+RHkZafQ2xmb4uoX+xT+6SMGhnqg78KBLDLx0eFK/kf8EA== X-Received: by 2002:a05:600c:a00c:b0:475:da13:2568 with SMTP id 5b1f17b1804b1-4775ce1ea77mr52306515e9.25.1762427188459; Thu, 06 Nov 2025 03:06:28 -0800 (PST) X-Google-Smtp-Source: AGHT+IFuMF9OgHdfBTsDYN5aYJl0CJUst2GhJK4Y16to+cgM45dg04f6bDtQdDR1sQbp0QSGsPQdIw== X-Received: by 2002:a05:600c:a00c:b0:475:da13:2568 with SMTP id 5b1f17b1804b1-4775ce1ea77mr52306195e9.25.1762427188026; Thu, 06 Nov 2025 03:06:28 -0800 (PST) Received: from localhost ([31.111.84.207]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-477632bda1asm35872415e9.3.2025.11.06.03.06.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Nov 2025 03:06:27 -0800 (PST) From: Andrew Burgess To: simon.marchi@polymtl.ca, gdb-patches@sourceware.org Cc: Simon Marchi Subject: Re: [PATCH] gdb: fix command_classes name clash In-Reply-To: <20251105225914.1492360-1-simon.marchi@polymtl.ca> References: <20251105225914.1492360-1-simon.marchi@polymtl.ca> Date: Thu, 06 Nov 2025 11:06:26 +0000 Message-ID: <877bw35sjx.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 6MUfviwHwaNBPmF2ozw0cGgbrbIzBFBVxSMM94AZn3c_1762427189 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org simon.marchi@polymtl.ca writes: > From: Simon Marchi > > I currently see this build failure: > > CXX guile/scm-cmd.o > /home/simark/src/binutils-gdb/gdb/guile/scm-cmd.c:551:54: error: =E2= =80=98const scheme_integer_constant command_classes []=E2=80=99 redeclared = as different kind of entity > 551 | static const scheme_integer_constant command_classes[] =3D > | ^ > In file included from /home/simark/src/binutils-gdb/gdb/defs.h:63, > from : > /home/simark/src/binutils-gdb/gdb/command.h:71:42: note: previous dec= laration =E2=80=98using command_classes =3D class enum_flags= =E2=80=99 > 71 | DEF_ENUM_FLAGS_TYPE (enum command_class, command_classes); > | ^~~~~~~~~~~~~~~ > /home/simark/src/binutils-gdb/gdb/../gdbsupport/enum-flags.h:58:9: no= te: in definition of macro =E2=80=98DEF_ENUM_FLAGS_TYPE=E2=80=99 > 58 | using flags_type =3D enum_flags; \ > | ^~~~~~~~~~ > > This looks like an unfortunate name clash. Fix it by renaming the > variable in scm-cmd.c. Approved-By: Andrew Burgess Thanks, Andrew > > Change-Id: I226b052c28eb8d09fd6840337845a387cd818085 > --- > gdb/guile/scm-cmd.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/gdb/guile/scm-cmd.c b/gdb/guile/scm-cmd.c > index d2172d986187..bfd11917df96 100644 > --- a/gdb/guile/scm-cmd.c > +++ b/gdb/guile/scm-cmd.c > @@ -548,7 +548,7 @@ gdbscm_parse_command_name (const char *name, > /* NOTREACHED */ > } > =20 > -static const scheme_integer_constant command_classes[] =3D > +static const scheme_integer_constant scm_command_classes[] =3D > { > /* Note: alias and user are special; pseudo appears to be unused, > and there is no reason to expose tui, I think. */ > @@ -576,9 +576,9 @@ gdbscm_valid_command_class_p (int command_class) > { > int i; > =20 > - for (i =3D 0; command_classes[i].name !=3D NULL; ++i) > + for (i =3D 0; scm_command_classes[i].name !=3D NULL; ++i) > { > - if (command_classes[i].value =3D=3D command_class) > + if (scm_command_classes[i].value =3D=3D command_class) > =09return 1; > } > =20 > @@ -903,7 +903,7 @@ gdbscm_initialize_commands (void) > =3D gdbscm_make_smob_type (command_smob_name, sizeof (command_smob))= ; > scm_set_smob_print (command_smob_tag, cmdscm_print_command_smob); > =20 > - gdbscm_define_integer_constants (command_classes, 1); > + gdbscm_define_integer_constants (scm_command_classes, 1); > gdbscm_define_functions (command_functions, 1); > =20 > for (i =3D 0; i < N_COMPLETERS; ++i) > > base-commit: 1518f2e087d31997711fc7f4472ab382c24fa903 > --=20 > 2.51.2