From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id MrYTDBIkp2n0vxIAWB0awg (envelope-from ) for ; Tue, 03 Mar 2026 13:10:26 -0500 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=LCsoswst; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 177D01E0DD; Tue, 03 Mar 2026 13:10:26 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 64B291E089 for ; Tue, 03 Mar 2026 13:10:25 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 685A94BA2E24 for ; Tue, 3 Mar 2026 18:10:24 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 685A94BA2E24 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=LCsoswst Received: from omta36.uswest2.a.cloudfilter.net (omta36.uswest2.a.cloudfilter.net [35.89.44.35]) by sourceware.org (Postfix) with ESMTPS id 203FE4BA2E0E for ; Tue, 3 Mar 2026 18:09:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 203FE4BA2E0E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 203FE4BA2E0E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1772561396; cv=none; b=HBZnUcU+n3C73BXTY3axiqDNfpEWRXH55RxYR3wmiD6vFH9crcFHf8EHJMPj3i8dNPN2c0akLMZUlCLFfR3WodurOeKt1XzeVnD22hgDWyrOTR8oicw8Gfatw3Xus4pc8cCR1gCitBCILET+xdH0iFfUfQSeEUeu3n62Pkxa5vA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1772561396; c=relaxed/simple; bh=XaJFYRMJ0fZNBPuacqzYSrDgZUPq9sT01/KVhh8Jkjc=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=sYSTfTdJjQV2iwWEarARd6JnMUDtdbAvd4JCls97IVZzlgAOr6KaY0ZppFSOiWyFKBwhHj/kjUSNzC5N3V7mkkmnhdQ9wLKZDTaSbpheeQs23rJAjQFpRurZOZ01e/cC2fKb+yfp1v6d5g1R34QG2GrtR4k8lPxb6jw6j3+ztsQ= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 203FE4BA2E0E Received: from eig-obgw-6007b.ext.cloudfilter.net ([10.0.30.166]) by cmsmtp with ESMTPS id xSSrvWNoIVCBNxUBvvjXlr; Tue, 03 Mar 2026 18:09:55 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id xUBrv3N14h8QWxUBsvpB7q; Tue, 03 Mar 2026 18:09:52 +0000 X-Authority-Analysis: v=2.4 cv=Mcdsu4/f c=1 sm=1 tr=0 ts=69a723f2 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=Yq5XynenixoA:10 a=ItBw4LHWJt0A:10 a=7CQSdrXTAAAA:8 a=zstS-IiYAAAA:8 a=FaEQb-whLolxGDE8dowA:9 a=a-qgeE7W1pNrGK8U0ZQC:22 a=4G6NA9xxw8l3yy4pmD5M:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=HvGX4Tu9cDNUw48/QgkbxZSzhUF41U/ARvj8ZHJqf3s=; b=LCsoswst4ySiUGJFAbU/L6Ra7L LNbj+0GwUOEwPFTjyzXPYCtXPKMkdDU3eqLc0axIi6tea+DLRTrXipVUx3GXHrztZH2915PR6zl8x 1+LewSfH+VqUSRl4xHJ27GXoH; Received: from 97-122-122-234.hlrn.qwest.net ([97.122.122.234]:58428 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vxUBr-00000001D7J-2wIr; Tue, 03 Mar 2026 11:09:51 -0700 From: Tom Tromey To: Matthieu Longo Cc: , Tom Tromey Subject: Re: [PATCH v2 1/9] gdb: switch tuple object helpers to Python limited API equivalents In-Reply-To: <20260303161659.397427-2-matthieu.longo@arm.com> (Matthieu Longo's message of "Tue, 3 Mar 2026 16:16:51 +0000") References: <20260303161659.397427-1-matthieu.longo@arm.com> <20260303161659.397427-2-matthieu.longo@arm.com> X-Attribution: Tom Date: Tue, 03 Mar 2026 11:09:50 -0700 Message-ID: <877brsss29.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.122.234 X-Source-L: No X-Exim-ID: 1vxUBr-00000001D7J-2wIr X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-122-234.hlrn.qwest.net (bapiya) [97.122.122.234]:58428 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfJpm56JIQqwNMGwaaS+yDPl0pjFV8dqyHoS1hpnl/+6dRD/JKvH4RIhrE8neAoPbid9swRcgI8oTB66DZ8Ksgm8S7CVTDWzLva4TOIvnn6Vg6tcV3vkF J6dhX2LXnjNcVQZ+4uhj95iIow0bgKzS5YjW7Ck90PCeAK+/awptZtl5bzEkGkdcHndqAZr30re4cB8DGDxBcjFM2u9P7zq3HOw= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> Matthieu Longo writes: > * PyTuple_GET_ITEM -> PyTuple_GetItem > * PyTuple_SET_ITEM -> PyTuple_SetItem > * PyTuple_GET_SIZE -> PyTuple_Size Thanks. At first I thought: > + gdbpy_ref<> bool_obj (PyBool_FromLong (is_a_field_of_this.type != NULL)); > + if (PyTuple_SetItem (ret_tuple.get (), 1, bool_obj.release ()) < 0) > + return nullptr; ... this was wrong, but it turns out that PyBool_FromLong is infallible. So I think this is ok. Approved-By: Tom Tromey Tom