From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id nKfdF1a1smmQ+CUAWB0awg (envelope-from ) for ; Thu, 12 Mar 2026 08:45:10 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=UAODhqjf; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 50A361E0DD; Thu, 12 Mar 2026 08:45:10 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C02131E08D for ; Thu, 12 Mar 2026 08:45:09 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 3715D4BBC0B9 for ; Thu, 12 Mar 2026 12:45:09 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3715D4BBC0B9 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=UAODhqjf Received: from omta34.uswest2.a.cloudfilter.net (omta34.uswest2.a.cloudfilter.net [35.89.44.33]) by sourceware.org (Postfix) with ESMTPS id 407004B920F1 for ; Thu, 12 Mar 2026 12:44:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 407004B920F1 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 407004B920F1 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1773319483; cv=none; b=Q2hDxxoEA5wVGZxlfV1MosMyX8pSHUAMe4H02SfhKQbzaPe+EajuaLVnzT9YRcf/Pe9HkCpdr3WY0ohc8n/8jxwf4DShI8eYXzjem7joMnk12m13gnYt2re3fs+vGFeGjxymKFPpH92oaHe0rLt4yLdBtyqN3DxQ+Ud/Jon3pyc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1773319483; c=relaxed/simple; bh=2FLmP3lTSyWxVm8vVNKsHdsXTPYstB2N2dALvk/vFlc=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=hvQwb3KjUByVBBHrltKPXIN0IzwptN0sNGxzUao5PHUWAPh4wV5iX7+U2zrqgC54JuyBsGoEgcLdtPNIJPEh2llyKazXRaA+5ZAWlg7HgS5Fh8cwOC5yjmY3khvNrUcRkDP1WXM9uTOQyBbefXJ7GFPEYbvbyhZAngfrbxGB428= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 407004B920F1 Received: from eig-obgw-5002b.ext.cloudfilter.net ([10.0.29.226]) by cmsmtp with ESMTPS id 0XDTwwsmDKjfo0fP8wolMn; Thu, 12 Mar 2026 12:44:42 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id 0fP7wZgynN3K10fP7wDcyS; Thu, 12 Mar 2026 12:44:41 +0000 X-Authority-Analysis: v=2.4 cv=UdRRSLSN c=1 sm=1 tr=0 ts=69b2b539 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=Yq5XynenixoA:10 a=ItBw4LHWJt0A:10 a=7d_E57ReAAAA:8 a=sb7rPhH6-kyXGgP9vpIA:9 a=jhqOcbufqs7Y1TYCrUUU:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=KrisUs/mHuwM++qORQ67z+mNDmae5KjI6jkX2u0eNtU=; b=UAODhqjfx3Hgt26ZWCKqFBbl1g rSdiIWYkxjO5tCMsk0kAsb0eB8yjv3k7POiU2yEjkKv6Y7LmxRXFFPd++WSNirSmWQGKtE8jFyXJQ mlQfBLjmlqd+uiEpffnr9D+PN; Received: from 75-166-225-82.hlrn.qwest.net ([75.166.225.82]:59146 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1w0fP6-00000002B7q-39y4; Thu, 12 Mar 2026 06:44:40 -0600 From: Tom Tromey To: Simon Marchi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 10/23] gdb/dwarf: change dwarf2_ranges_read to return bool In-Reply-To: <20260311180825.720803-11-simon.marchi@efficios.com> (Simon Marchi's message of "Wed, 11 Mar 2026 14:05:35 -0400") References: <20260311180825.720803-1-simon.marchi@efficios.com> <20260311180825.720803-11-simon.marchi@efficios.com> X-Attribution: Tom Date: Thu, 12 Mar 2026 06:44:38 -0600 Message-ID: <877brhtdxl.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.225.82 X-Source-L: No X-Exim-ID: 1w0fP6-00000002B7q-39y4 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-225-82.hlrn.qwest.net (bapiya) [75.166.225.82]:59146 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfEJH4hrAZ5cl4GbbXQoTFZNq/tvlz6XP/dOpfXdXV1VotiNOrjaJWc3zQVk3ISFlCyvIxqoa5UnnDdtPGRNEAfksbO7XQjURCOrPkuBAkcqAeP9ppFD5 wSL3u5Puxq2XBGYwvXvXdcLqqOcpemY/5/ezo3FHGEh3CAkovLWqKeqhYjYXexgoYZAL4L54IQPqi5WmGCN2qIeudjKeVI3ES9s= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Simon" == Simon Marchi writes: Simon> -int Simon> +bool Simon> dwarf2_ranges_read (unsigned offset, unrelocated_addr *low_return, Simon> unrelocated_addr *high_return, struct dwarf2_cu *cu, Simon> addrmap_mutable *map, void *datum, dwarf_tag tag) Simon> { Simon> - int low_set = 0; Simon> + bool low_set = false; Simon> unrelocated_addr low = {}; Simon> unrelocated_addr high = {}; I was going to suggest std::optional here, but it seems "low_set" is misnamed and it really tracks whether both values have been set. Tom