From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 8b3nFYmNvWmdpjEAWB0awg (envelope-from ) for ; Fri, 20 Mar 2026 14:10:17 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=RTZUACGj; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 458E41E08C; Fri, 20 Mar 2026 14:10:17 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 853411E08C for ; Fri, 20 Mar 2026 14:10:16 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 2A8954C91769 for ; Fri, 20 Mar 2026 18:10:15 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2A8954C91769 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=RTZUACGj Received: from omta40.uswest2.a.cloudfilter.net (omta40.uswest2.a.cloudfilter.net [35.89.44.39]) by sourceware.org (Postfix) with ESMTPS id 2F5384C900C3 for ; Fri, 20 Mar 2026 17:26:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2F5384C900C3 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2F5384C900C3 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1774027599; cv=none; b=Ck5C7jSgYZ3jXQI1OknHxda2nJNrwIImlTVtVG11v6p3G5qs3DhPL/shR8WE+B/CLR4Lxtwn1JAlEiWX3E4uiWfpCFo+KyYoRXGEEDMu6jfcPwl96RDt/1dEzYHH5InjsFRmF5nN2mozVggnj4+jAZZYeF8/b8EkqkoCrTbC5NA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1774027599; c=relaxed/simple; bh=OzAl1Gfpw0ezLfe9CCxVHCLiF8qa9WXPhndxlAAh1Bs=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=csQbMk4oL+14Fc5ZjngjI/MPBBhdEfUw3Ah6AMYNyAD44iv9yw1rivRu5ELc1Hhh+QRs0n3Kv87NiDBnSAAtVlTrMi7DLYompD45uKnDGBCFfCqglSc/GlzZkflPWJQFSgDIKTHCqHYN2lFdTKxZmhRxO9ZYrZAnK3Y118hJynA= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2F5384C900C3 Received: from eig-obgw-6006b.ext.cloudfilter.net ([10.0.30.211]) by cmsmtp with ESMTPS id 3c0Lwd7vxaPqL3dcMwF9sM; Fri, 20 Mar 2026 17:26:38 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id 3dcLw7d3FvXvH3dcLwweGs; Fri, 20 Mar 2026 17:26:37 +0000 X-Authority-Analysis: v=2.4 cv=e4IGSbp/ c=1 sm=1 tr=0 ts=69bd834d a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=Yq5XynenixoA:10 a=ItBw4LHWJt0A:10 a=pGLkceISAAAA:8 a=ca_7ZtesDVGxRTne0W4A:9 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=6ozl1ah47REYYqx4pmg9QhVXJvZo62HnKn1K+xdHWgk=; b=RTZUACGjcXWyOShP9rOM/le5lg 0552laAs7X08KxwoWoPlT6XF7ivuSEyWi0K1lDK8OSu44Wdhg+qtwHH206Hk8YLBJLIEDN8bYP89w CwagBp3WPeLU5Tw4tSHLH0K96; Received: from 75-166-225-82.hlrn.qwest.net ([75.166.225.82]:47154 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1w3dcK-000000023Q2-3rum; Fri, 20 Mar 2026 11:26:37 -0600 From: Tom Tromey To: Aditya Vidyadhar Kamath Cc: ulrich.weigand@de.ibm.com, simon.marchi@polymtl.ca, tom@tromey.com, gdb-patches@sourceware.org, Aditya.Kamath1@ibm.com, sangamesh.swamy@in.ibm.com Subject: Re: [PATCH v2] Add support for recording minimal symbols in AIX for non DWARF compiled library function record. In-Reply-To: <20260320121637.91452-2-akamath996@gmail.com> (Aditya Vidyadhar Kamath's message of "Fri, 20 Mar 2026 17:46:38 +0530") References: <20260320121637.91452-2-akamath996@gmail.com> X-Attribution: Tom Date: Fri, 20 Mar 2026 11:26:35 -0600 Message-ID: <877br69zuc.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.225.82 X-Source-L: No X-Exim-ID: 1w3dcK-000000023Q2-3rum X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-225-82.hlrn.qwest.net (bapiya) [75.166.225.82]:47154 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfKFlFb0nIKEjOsm4O/ZT10ebW3Wr4iDYMxXbFoHPnPN1xwsE19T/er1yEHKq7IcJAAytzULCWcyvud8uDphrd3ztz+RBbCm9ScJ+vlXtTw4sMVZiR2ND 60oQFO7Ox5PfRcl+7y2SXHrO+dxA/s3CNpxuAW0wrCRL9eKMGfCf0BS/MpKW+1Mu+0mi9tLIFzKqIM+ZrEvzQNNY1jyIUC1tOsw= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> Aditya Vidyadhar Kamath writes: > This patch restores recording of minimal symbols in xcoffread.c, while keeping the removal of: > - STABS-based symtabs > - compunit_symtabs Thanks for updating the patch. I'm sorry I didn't notice / remember this before, but there is one more change that should be made. > + bfd *abfd = objfile->obfd.get (); > + long do_we_need_storage = bfd_get_symtab_upper_bound (abfd); > + > + if (do_we_need_storage <= 0) > + return; > + > + gdb::unique_xmalloc_ptr sym_table > + ((asymbol **) xmalloc (do_we_need_storage)); > + /* Get the number of symbols we need. */ > + int number_of_symbols = bfd_canonicalize_symtab (abfd, sym_table.get()); > + > + /* Return on error. */ > + if (number_of_symbols < 0) > + return; This code should be replaced with a call to gdb_bfd_canonicalize_symtab. That was added to avoid some pathological behavior, see the comment in gdb_bfd.h and/or the associated bug. Since you don't want an error here you should pass 'false' for should_throw. I forgot about the existence of this earlier and only remembered it when I was looking at something else... thanks, Tom