From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 8aOfDa4l+mmnChcAWB0awg (envelope-from ) for ; Tue, 05 May 2026 13:15:26 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=bftLYNXR; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 337A21E0BA; Tue, 05 May 2026 13:15:26 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id AC7FC1E067 for ; Tue, 05 May 2026 13:15:25 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 3D0F84BA2E32 for ; Tue, 5 May 2026 17:15:25 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3D0F84BA2E32 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=bftLYNXR Received: from mail-oo1-xc2a.google.com (mail-oo1-xc2a.google.com [IPv6:2607:f8b0:4864:20::c2a]) by sourceware.org (Postfix) with ESMTPS id 57FC84BA2E27 for ; Tue, 5 May 2026 17:14:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 57FC84BA2E27 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 57FC84BA2E27 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::c2a ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1778001292; cv=none; b=HV8arq6/hy6/F7Z/ptkVzGWYvBatMYkMP76MG73mE5lZaO+yr9XCTIYc4AM3J9lcJ21k9GJ0Sle/G9ZJXVwe6Xd7YxCBpJ/Pbyo9KLStwOO5RXTY6X8K5X2ndfWvp1ytkJ1D0VbUjlbK9R6QND6LfSNsWj5O8r7sSfG4Jc7lxTQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1778001292; c=relaxed/simple; bh=NyGvON5wow1Uvu06LoPvBQm8OyqZ/JPVbn3Cl0vCyI4=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=XKJzSHGbItksv+Oiv5rBbRjSpdvvNDGvgdV9MhRtca8cxHfqlvyJLhpO3XRhdr1ybFeuJ0KtxzFwUKs97NoQuMNHxZMVA+NpAjIfQrfpKct153k+rmuhEWSHr23aOtglyB6b9NCNUSQfkTyeLa57Q13Ap6S/1w8zBna0RZtYZBo= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 57FC84BA2E27 Received: by mail-oo1-xc2a.google.com with SMTP id 006d021491bc7-682fce74c06so4722981eaf.3 for ; Tue, 05 May 2026 10:14:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1778001291; x=1778606091; darn=sourceware.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=fwVHQYK48Hr9H180azkFrPL8t2GA/MG8GBICjqUxkHg=; b=bftLYNXRpKiyGh4FR9cJgJNGqZVssszyexXJJlz4qVpZbXqcFtfQJBBLEKGBrefhSB fAknBHZbOPkMR2sypFOOkXvNy8P9U21EgZeHO8L/61/sLTyxJYF4tZ8l8idI2EjZ0utU eMFSZIeB21AswDrh1b3W2yUV39neTVcs6c62aHETcWx+JIaYXTLtoyHnIetz6p4XIC6e JoOMuhKySUMhVJN6khqVymK1LW12E3eUSN6FWZIXatoZ/kX0gpnjDNyKOlCXLt+lyR0I aCJZAOn3/Vmg7r2Zl58wqhkX/VYyZPOf5Q+P8zIGxx8dpnatXDeYBd+dVW6fuVYK2jI7 93QQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778001291; x=1778606091; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=fwVHQYK48Hr9H180azkFrPL8t2GA/MG8GBICjqUxkHg=; b=XRNtWrO3mTflj+sLZL3+Kx79MNxvz8fH/V7rmPkXGBBRz9cxkBBEXyfK1Nye9DmwkX 1Pk9GfM3OZ5+m7QWxHpMwb8fRZMuSMQeIPrW0zQNmygiSakZfa0k8QhhUdZ/guSWle9D QrT5stRoAP/Jk7PsefPBHtg/4Ru1KiD3JEfd+Fry2Rsp8wKk0kq505elMbCL9pGc6ny1 Wr0gpAYDn/t46be7Y0PBBLWAae24PWMmNqEmSpnn6pJM3xaSkY/8psiOrcSWg/sEbviJ pJi/Dt1Xs393SDpWBCLwv2kgq1Z1984YQETzkVcpqB6+MXErU4jH0PmvVDSxx/9zR7xI FtEA== X-Forwarded-Encrypted: i=1; AFNElJ/utimhtqV/6HYj7UcyWLOXD2mFGujUN73sXge+ZW/AUvMtbobvG5rWPu7Rc7UNWhAgZNRjffAYdQ0mHQ==@sourceware.org X-Gm-Message-State: AOJu0Ywfp0HqX68iJMvrXxTEMXhhBmX65ZOnMwX4/OrvqbsSYURwzFmO 39AzBHyyAsUkf1sYx+3WzDc4tH2IunbawmXgdyQXyXWBdlhL1bB5KVqnAGMFFerfL4GaGoii4OA tdXE= X-Gm-Gg: AeBDiesqBuo5HdegUqbZUHdZ3ItzRzG7JDbsKaF4QM0Qn8yniQ4/ziBcc0maXSU8zag lxVqaILZUganHNyhgA+8d5yVQt6Vt5Egn+Q2J6md3PK/0mFRniTI7IdqSNeov9dVWS99Kj/Q6Qd R2fK+T+GuZIQHv3Es8w7NcYRZJAqzWYO/OvtHgWSOtd6KfOkGcwIRZg4f/wHwYpxqLHWxwCUBzV 4r+F6llvDjROPsFu9R/oD0qwvB4meL43tbbxI7aBvkhQFA74ICCTlL1vhYhGUpapX54Tnl9VBwH ZfaB1pFOx098rXTSHt89y4rqKHNmofxWykkKngoqFXk9j85r0z9twlgKt0sg2VF+fI8yMFYwySK i/72kJmKy585561ZyMmIPN0UqNxS0G8XYyRnij6XMZcv4+XrP9FKk2rhYFarYwf179mPV8FMHZ/ Wv7BKHuRr10VSwe4+KagaN3oIRuusNDYgMnYlGxS8wby/BMILcbISqzg== X-Received: by 2002:a05:6820:2228:b0:67d:e7c3:3c6c with SMTP id 006d021491bc7-69697e10ecamr8104150eaf.53.1778001291247; Tue, 05 May 2026 10:14:51 -0700 (PDT) Received: from bapiya (75-166-225-82.hlrn.qwest.net. [75.166.225.82]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-43454d53a55sm14153672fac.16.2026.05.05.10.14.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 May 2026 10:14:50 -0700 (PDT) From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH] Return iteration_status from iterate_over_objfiles_in_search_order_cb_ftype In-Reply-To: <6c186838-6046-4781-b90b-dac816279879@simark.ca> (Simon Marchi's message of "Tue, 5 May 2026 13:13:28 -0400") References: <20260505150228.474870-1-tromey@adacore.com> <6c186838-6046-4781-b90b-dac816279879@simark.ca> X-Attribution: Tom Date: Tue, 05 May 2026 11:14:49 -0600 Message-ID: <877bphg4mu.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Simon" == Simon Marchi writes: >> - return true; >> + return iteration_status::keep_going; >> } >> >> if (compare_filenames_for_search (obj->original_name, name)) >> { >> objfile = obj; >> - return true; >> + return iteration_status::keep_going; >> } Simon> These last two look wrong. I even re-read the patch to double-check :( I will postpone fixing this until I can see if a test case is possible. Tom