From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 1SWfFtwh/mnwPiQAWB0awg (envelope-from ) for ; Fri, 08 May 2026 13:48:12 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=WNt+uhOZ; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 454F21E0BA; Fri, 08 May 2026 13:48:12 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 77AB91E067 for ; Fri, 08 May 2026 13:48:11 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 846C24BA2E11 for ; Fri, 8 May 2026 17:48:04 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 846C24BA2E11 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=WNt+uhOZ Received: from omta036.useast.a.cloudfilter.net (omta036.useast.a.cloudfilter.net [44.202.169.35]) by sourceware.org (Postfix) with ESMTPS id D2ABF4BA2E0F for ; Fri, 8 May 2026 17:47:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D2ABF4BA2E0F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D2ABF4BA2E0F Authentication-Results: sourceware.org; arc=none smtp.remote-ip=44.202.169.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1778262457; cv=none; b=koHKlpXvCeUQc1v9q8bivo9ud0Pm0pElS8ygPHPWRmDizC2TGCjvy1hapw4rPX/2ody7jYQ8OXExCuz3c9kHE624KJM9v/EMAaC8aqP2W7IcbxRo2ztVklJZ0oXq3nuwy58KrfNUO1dGHICtFahcppnx+Ti1sTa0JnQSuQO+uaU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1778262457; c=relaxed/simple; bh=NlWiX6M89x37deRHeSMfLEYQrptY4bWGjKlNsOOfXC0=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=JuhkpnjLbkBlY3pkMcIjHfEVyv+SuElMk3RzIwj/ClK8fObS+bo0pLdb3RfWGYRexUVTrkHhzaw8oZLfyAle2LBE8v4+nvzhjaoLb0RTMkuBKJNpaH95p2u6EbeL5m2XzwG6dVjeAtwo4r0Mvnf9G5ST0urwOuj1+sW/1OKgZbA= ARC-Authentication-Results: i=1; sourceware.org; dkim=policy (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=WNt+uhOZ reason="signing key too small" DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D2ABF4BA2E0F Received: from eig-obgw-6007b.ext.cloudfilter.net ([10.0.30.166]) by cmsmtp with ESMTPS id LNeuw93glnv6VLPIWwFa7v; Fri, 08 May 2026 17:47:36 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id LPIVw5sMGtuVJLPIVwrTCW; Fri, 08 May 2026 17:47:36 +0000 X-Authority-Analysis: v=2.4 cv=BNWzrEQG c=1 sm=1 tr=0 ts=69fe21b8 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=NGcC8JguVDcA:10 a=ItBw4LHWJt0A:10 a=KKAkSRfTAAAA:8 a=zstS-IiYAAAA:8 a=rOCVXKwccaIN3YO6m0sA:9 a=zZCYzV9kfG8A:10 a=cvBusfyB2V15izCimMoJ:22 a=4G6NA9xxw8l3yy4pmD5M:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=cT6XMSvl7fSxpKAnjKgP7aTnQLbg+9FU+/DB7X5ljEQ=; b=WNt+uhOZWiGPloCOxOZ4bMnRLq cKQrPv4X8Xl4jQdT8vl/EgyMB2XzAgCEFTnd8TdWv5PgeO4DI5KfZuZdr5gKthnJ6Xo1D9uV2qioB UtTLz6wQqqWTtCstf+9f1KyOy; Received: from 75-166-225-82.hlrn.qwest.net ([75.166.225.82]:42704 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.99.2) (envelope-from ) id 1wLPIV-00000004KhW-0ATM; Fri, 08 May 2026 11:47:35 -0600 From: Tom Tromey To: Thiago Jung Bauermann Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2 00/37] GDB: testsuite: Fix top-level returns In-Reply-To: <20260429230432.60487-1-thiago.bauermann@linaro.org> (Thiago Jung Bauermann's message of "Wed, 29 Apr 2026 20:03:51 -0300") References: <20260429230432.60487-1-thiago.bauermann@linaro.org> X-Attribution: Tom Date: Fri, 08 May 2026 11:47:33 -0600 Message-ID: <877bpdoksq.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.225.82 X-Source-L: No X-Exim-ID: 1wLPIV-00000004KhW-0ATM X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-225-82.hlrn.qwest.net (bapiya) [75.166.225.82]:42704 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfBseKTNUjsi03cXNNgEn+BKI9rm95hQ8dg+v+TcArJXRdJU8tWtwm0AW0bNgxm2nFsnULlC6aDQOz78AD76SdHDyOtenKGbRFA+2iYapZBSAxl30twEQ gyDAXfpoZq3BwOhI9U3VdaDGGHIlo0cS2SKBV7b4nBkoQ0xca2l8fPnmUtoCyYS5meXB+RoFloJLhQ/yn1haOFXUJy+mQgt4pB4= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Thiago" == Thiago Jung Bauermann writes: Thiago> In the past, when testcases needed to return early they would do a "return Thiago> -1" or sometimes a "return 0". Nowadays the style is to do do a "return" Thiago> without any value. Thiago> When creating new testcases, we often copy snippets from older files which Thiago> do return a value so the old style keeps spreading. In an effort to reduce Thiago> the bad examples, this patch series fixes the return statements that were Thiago> easy to find and verify for correctness. I didn't try to remove all of the Thiago> "wrong" instances. I didn't really read these patches in depth. However I agree with the general approach and I think it is a good change for the reasons you stated. I did randomly sample the patches to see if they made sense. Anyway I think these should go in. I can't really imagine doing a more in-depth review. Approved-By: Tom Tromey Tom