From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ae7cHAgYD2poyQwAWB0awg (envelope-from ) for ; Thu, 21 May 2026 10:34:48 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=AbbDqCVq; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 6E0FF1E098; Thu, 21 May 2026 10:34:48 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C30981E024 for ; Thu, 21 May 2026 10:34:47 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E35FF4B7A1C6 for ; Thu, 21 May 2026 14:34:46 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E35FF4B7A1C6 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=AbbDqCVq Received: from omta40.uswest2.a.cloudfilter.net (omta40.uswest2.a.cloudfilter.net [35.89.44.39]) by sourceware.org (Postfix) with ESMTPS id 380B94BBCDF8 for ; Thu, 21 May 2026 14:34:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 380B94BBCDF8 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 380B94BBCDF8 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=35.89.44.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1779374062; cv=none; b=VilvZWiS4KLDIyRDmA+ws9YH9AywrSXVJ5zDX0JvLBXMfF697jCUtZnRkYmbB/sRpu991X+9A8x3wFD9igQ4GwBZiJe9w8Mi22wIrnkOYbSP0joFfWslo2UhSyGMQi2pC/m1QZHCVwjLOHjp+WPM8nRMT/PODktDJR8VeCHn/jU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1779374062; c=relaxed/simple; bh=z+K47f3q4+GaT4K3IEgYIYOqGsnqaT+eK1UL5TxwKyc=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=YIbzcIS4P1eMdR5L8K8TiL6HQmXm3IpQAFtYp3nvzHTvVoz0aCEj90bQ8jzWsBezMXw0jDmYXy6+rgyeLaufn+1flaHfrON0J8ijdVF0c43GfaJJe31L7mU1S7v8zo6jzjD6jWPrRIOGddtfDPkA+NnaJJK6ShItVcLmqNlKIOc= ARC-Authentication-Results: i=1; sourceware.org; dkim=policy (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=AbbDqCVq reason="signing key too small" DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 380B94BBCDF8 Received: from eig-obgw-5001b.ext.cloudfilter.net ([10.0.29.181]) by cmsmtp with ESMTPS id Q18GwOzQUjgweQ4TdwcNzQ; Thu, 21 May 2026 14:34:21 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id Q4TbwzIqF5zk0Q4TbwgCC9; Thu, 21 May 2026 14:34:19 +0000 X-Authority-Analysis: v=2.4 cv=GPEIEvNK c=1 sm=1 tr=0 ts=6a0f17ec a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=NGcC8JguVDcA:10 a=ItBw4LHWJt0A:10 a=_ZhYKdCeAAAA:8 a=zstS-IiYAAAA:8 a=YwYm_g4gi_Md4cXV8xEA:9 a=uqOk3ZSnBfCTOznnrPA1:22 a=4G6NA9xxw8l3yy4pmD5M:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=TXXEo0snBfQ8uaogiGt3KAxmL02DZ7hZbTNOQsSdU34=; b=AbbDqCVqWvZB18ivHrf3rUqgxW dteZ/vQzPV8ZYgHWfHRlPTRiWKHEMrX/FZAhCGmL6LXCpc7GYrPkDdL4LLhAUEo/rM8nQ1Zgoa2FT izrUle3IZnT2bZ3ffQBwSYUGw; Received: from 75-166-225-82.hlrn.qwest.net ([75.166.225.82]:56814 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.99.2) (envelope-from ) id 1wQ4Tb-00000002fDH-04Gn; Thu, 21 May 2026 08:34:19 -0600 From: Tom Tromey To: simon.marchi@polymtl.ca Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 2/2] gdb: remove complaint_interceptor::g_complaint_interceptor In-Reply-To: <20260521040112.1618748-2-simon.marchi@polymtl.ca> (simon marchi's message of "Thu, 21 May 2026 00:00:49 -0400") References: <20260521040112.1618748-1-simon.marchi@polymtl.ca> <20260521040112.1618748-2-simon.marchi@polymtl.ca> X-Attribution: Tom Date: Thu, 21 May 2026 08:34:13 -0600 Message-ID: <877bowal22.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.225.82 X-Source-L: No X-Exim-ID: 1wQ4Tb-00000002fDH-04Gn X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-225-82.hlrn.qwest.net (bapiya) [75.166.225.82]:56814 X-Source-Auth: tom+tromey.com X-Email-Count: 12 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfI8/p9bY9pfvD2Azu5PavhnTuHjr1426Yt2Pv2db4bicZCiulkc0Ulf3N/YAYZEm1s59StTYe0EckFXrNGuLA0pxdnRpAUt4ScCMsnbg7iMysa2ceRZq dpmpV2TaO+e4bUf90bMetrT8fjd2xsc0L4VV+P4+UmaH+Gbc+bct+wNg0u9zjQEx4arJV3nv3wMaXYPW8VH0I/immzXuscj7dEo= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Simon" == simon marchi writes: Simon> From: Simon Marchi Simon> The thread_local g_complaint_interceptor pointer is unnecessary. The Simon> complaint_interceptor constructor registers itself as the warning hook Simon> via m_saved_warning_hook (this), so when complaint_internal dispatches Simon> through the warning hook, it lands in complaint_interceptor::warn with Simon> 'this' already pointing at the registered interceptor. Inside warn, Simon> g_complaint_interceptor and 'this' always refer to the same object. Simon> Replace g_complaint_interceptor->m_complaints with m_complaints in Simon> complaint_interceptor::warn and remove g_complaint_interceptor. Ok. Approved-By: Tom Tromey I don't remember the code too well but I do wonder if we should just have each set of complaints be completely independent and emit them all at some spot guaranteed to be on the main thread. Like, instead of 'complaint' function, only expose a method on some object. OTOH I don't think we should spend any more time on complaints than is strictly necessary. Tom