From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id fSZ9L0iFcGpyVgIAWB0awg (envelope-from ) for ; Mon, 03 Aug 2026 08:10:48 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=ZsW8z4pM; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id B1E9C1E099; Mon, 03 Aug 2026 08:10:48 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E53C31E099 for ; Mon, 03 Aug 2026 08:10:47 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C4F814BB1C22 for ; Mon, 3 Aug 2026 12:10:46 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C4F814BB1C22 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=ZsW8z4pM Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 07C954BA2E29 for ; Mon, 3 Aug 2026 12:10:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 07C954BA2E29 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 07C954BA2E29 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1785759022; cv=none; b=EveukGScHj9QJhdW7EIVf0rfB13MVm17dBHgtZd7KsmuJgvJ2iZDZY31FiVO6ThM9+VIaLd5grFFpuZx4r5cSmwJISO2/CkKmD4vxt8LqsqHN9CfV4nwk//xgi/2dULBXEhSKyw7SHOrKfPoL4cpjHIr/G45fWdc3b7Bf1GNc/k= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1785759022; c=relaxed/simple; bh=bzQ+2U4Xd96A8WTJBgNAAXde0mzC7m38XOWd+tCmk6k=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=VD/z+nQ4pwpxXBUHrVvFgNKqrtLD1dktH66+C1Ja95Idf/LOhVIKtWQjIzMbtQUD+VjySCYErV2bRfK4IGs09Y61GST1dZ9IYQOrd6IkxEQjfI1hdTDYqXru2EXs2eLXCeK3WKJlP36fvuNJBSzuBA5d5y831YnpOvsfQLsdZ5E= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=ZsW8z4pM DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 07C954BA2E29 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1785759021; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VnBmcZOXDqQl3HN71+InfXQ72lmCfspo4YPhUwopd0U=; b=ZsW8z4pMcoRUzi54UM1VHkh77Wl6VUInmztvHuaLBsKttxeAo2+pK2ydYkwmkf/A1pdtPR hmET0GenAW4L6bnY8X2P9VR+kZfKwVEJN19n/qN5ssph40l8s7VKnP2zKd7A8OP9MPO20J Lmp/aU0yysb3c3AuTOyb0XiQcOJnzjk= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-324-4OiggHNQP4CblWV3_2JIvA-1; Mon, 03 Aug 2026 08:10:15 -0400 X-MC-Unique: 4OiggHNQP4CblWV3_2JIvA-1 X-Mimecast-MFC-AGG-ID: 4OiggHNQP4CblWV3_2JIvA_1785759014 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-49808ea1b64so26400975e9.1 for ; Mon, 03 Aug 2026 05:10:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785759014; x=1786363814; h=content-type:mime-version:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=VnBmcZOXDqQl3HN71+InfXQ72lmCfspo4YPhUwopd0U=; b=JFN0EaMkn12ZBZy3wUYyoKsNrt27YYXBWLpCKuT8PHZe0k4ZZm9/hZ506FKg7Yxfub eR1IajLx32u7VuiEQfgnvrRre33WV3S9naDTwXSbf36GHFNcd6cM2wXbQf8M955M/YuZ KQFwWNlMFSgQiL4IlYIzUvT+PGQjusfpibMxK5yeG8o/sIflUKrNelDy0Dh4UnLozpRc teJne8sQxbjPgtYbq2OD1pZQpKqaxRAcrz7j7hCI5nAfPd2f2iL8cmXTlsv7JZmWQu6/ eSP+f/orXUzg8xfj9ce4VW6SSBEgmu7wUviJwoxQKefKKQbyqU4+8mE15nCZ21uoH06b v/vw== X-Forwarded-Encrypted: i=1; AHgh+RosH3ZaQrhXyvtGp/DlyN7HzdOebjFMKT+PGYkDkQyW5j7qq3gzFvRnyIhOeOXgKlM7B1I5x9GKLyTQZg==@sourceware.org X-Gm-Message-State: AOJu0Yzk5WibAnuG9XlTDovcJ8t3HyRkX6UE5SBoYwO0nS2b+2t7SqZm BlZ4qKdYs/2IzktrMew52EAqBIGXovCo1FT7jrTuI14aWgCqakSJVxrlECdgOKCiCdC39afFmtO m8MTLoLMGdHM1uQRA4C0cy7DJIFph2h2CdCY8HvZrytC8EqQNxZlsjz5fsRlU9cU= X-Gm-Gg: AR+sD11jHLcLSL341lgxv+DRG1h1AFmJdgxQvX+n17ruAYjac4caNESjPW7msxAdPFy YGL5Ug9kSwFYRy1b/44fYyjWdgZDCQv5wwaL21pG4UQotSlkUwuaJmAWu06n5pIUJFxsH1QxKro 8AAOUBtVjfN8NxErjMPGvMqXcXvB0WLbzUkTQsYAFyjF1uWpfLuzf7gIe1H/5qoMfybgH0h1gvR Mdemy3UmIbLhXJThonEblqq0wJ7XfWIoIXy1ZiJ4KUrQuGcM7uvu1JyCNRnwzBLbHVOB3zcRI67 q+9l9YfBYm6HA2lmH9d/MQr7DhY+XyWajKjVSw3khxIPLoNCl0e5jJz81zmatZHG4hj+3qORvmU 7CIQIHtZD/zEAOBcv X-Received: by 2002:a05:600c:46c3:b0:494:1f7:8057 with SMTP id 5b1f17b1804b1-4980eb8d081mr164406825e9.1.1785759013236; Mon, 03 Aug 2026 05:10:13 -0700 (PDT) X-Received: by 2002:a05:600c:46c3:b0:494:1f7:8057 with SMTP id 5b1f17b1804b1-4980eb8d081mr164405105e9.1.1785759012191; Mon, 03 Aug 2026 05:10:12 -0700 (PDT) Received: from localhost (92.6.93.209.dyn.plus.net. [209.93.6.92]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49808191ef9sm252191815e9.1.2026.08.03.05.10.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Aug 2026 05:10:11 -0700 (PDT) From: Andrew Burgess To: Roger Sayle , gdb-patches@sourceware.org Cc: 'Hans-Peter Nilsson' Subject: Re: [PATCH] Avoid seg fault in sim/cris/sim-if.c In-Reply-To: <006501dd21f7$5fa6ab60$1ef40220$@nextmovesoftware.com> References: <006501dd21f7$5fa6ab60$1ef40220$@nextmovesoftware.com> Date: Mon, 03 Aug 2026 13:10:11 +0100 Message-ID: <877bm7mml8.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Kjq4X5GxrZXp4Kl2IQRMZJ1mKvDRkaGCVq5X66bij0I_1785759014 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org "Roger Sayle" writes: > Typing "target sim" in GDB built with --target=cris-elf, crashes immediately > after being launched with "gdb ./a.out". The issue is that STATE_PROG_ARGV > may return NULL, and this isn't tested before dereferencing the pointer. > > If approved, please could someone commit this for me. > Thanks in advance. I pushed this. But also, I owe you an apology. For some reason I was not able to apply this patch directly from my email client to a git tree as usual, so I ended up copying the contents by hand. In the process I forgot to make you the patch author, something I only spotted after pushing to master. This was not intentional, and I really do apologise, I did not intend to take credit for this fix. Unfortunately, there's no simple way I can fix this mistake. I will try to take greater care in future. Thanks, Andrew > > 2026-08-01 Roger Sayle > > ChangeLog > * sim/cris/sim-if.c (sim_open): Check that prog_argv isn't NULL. > > > diff --git a/sim/cris/sim-if.c b/sim/cris/sim-if.c > index 12c80983208..3babbb058b7 100644 > --- a/sim/cris/sim-if.c > +++ b/sim/cris/sim-if.c > @@ -770,8 +770,9 @@ sim_open (SIM_OPEN_KIND kind, host_callback *callback, struct bfd *abfd, > for (envc = 0; environ[envc] != NULL; envc++) > len += strlen (environ[envc]) + 1; > > - for (i = 0; prog_argv[i] != NULL; my_argc++, i++) > - len += strlen (prog_argv[i]) + 1; > + if (prog_argv != NULL) > + for (i = 0; prog_argv[i] != NULL; my_argc++, i++) > + len += strlen (prog_argv[i]) + 1; > > envstart = (envtop - len) & ~8191; >