Re: [PATCH] gdb/python: add allow_pending parameter to gdb.Breakpoint constructor

[Tom Tromey <tom@tromey.com>]

>>>>> "Tomáš" == Tomáš Hrnčiar <thrnciar@redhat.com> writes:

Tomáš> Add a new allow_pending parameter to the gdb.Breakpoint constructor.
Tomáš> Setting the new parameter to False causes GDB to raise an error instead
Tomáš> of creating a pending breakpoint.  By default this parameter is True,
Tomáš> which allows pending breakpoints to be created, preserving the existing
Tomáš> behaviour.

Hi.  Thanks for the patch.

This is PR python/12816 so please add this tag to the commit message:

Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=12816

Tomáš> +  ** The gdb.Breakpoint constructor now takes an optional
Tomáš> +     'allow_pending' argument.  Setting it to False causes GDB to raise
Tomáš> +     an error instead of creating a pending breakpoint.

I wonder about calling the new argument 'pending' instead.  I tend to
think that's a bit nicer since we already match the parameter and
attribute name for 'temporary'.

thanks,
Tom