RE: [PATCH] new MI command for pattern filling of memory regions

Giuseppe MONTALTO
2012-05-10T11:41:23Z

> -----Original Message-----
> From: Tom Tromey [mailto:tromey@redhat.com]
> Sent: Wednesday, May 09, 2012 8:11 PM
> To: Giuseppe MONTALTO
> Cc: gdb-patches@sourceware.org
> Subject: Re: [PATCH] new MI command for pattern filling of memory
> regions
>
> I was told off-list that you are covered by your employer's assignment.
> So, good.

I was almost sure about that, though I had no way to check it.

>
> Giuseppe> the proposed enhancement is about memory filling.
>
> I started to review this, but I wondered why a new command is
> necessary.
>
> It seems like you could send any hex string to want to
> -data-write-memory-bytes.
>
> Alternatively, if you really want the repeat count, why not just add an
> optional argument to -data-write-memory-bytes? That would seem to be
> simpler.

I didn't want to alter the syntax of an already existing command.

I did so, in the past, on a custom version of gdb, and this caused me a
lot of trouble while migrating to a newer release: I discovered that
the new release featured another argument to a command I had amended,
which was conflicting with my own changes, so I had to rework both!

Giuseppe