From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8119 invoked by alias); 21 May 2012 15:27:26 -0000 Received: (qmail 8086 invoked by uid 22791); 21 May 2012 15:27:24 -0000 X-SWARE-Spam-Status: No, hits=-6.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 21 May 2012 15:27:04 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q4LFR4GD009878 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 21 May 2012 11:27:04 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q4LFR2Hb006718 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 21 May 2012 11:27:03 -0400 From: Tom Tromey To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: -lmcheck new FAILs for __FILE__ [Re: FYI: fix PR macros/13205] References: <87ehqjoopc.fsf@fleche.redhat.com> <20120519075208.GA3761@host2.jankratochvil.net> Date: Mon, 21 May 2012 15:27:00 -0000 In-Reply-To: <20120519075208.GA3761@host2.jankratochvil.net> (Jan Kratochvil's message of "Sat, 19 May 2012 09:52:08 +0200") Message-ID: <8762bph7w9.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.95 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-05/txt/msg00771.txt.bz2 >>>>> "Jan" == Jan Kratochvil writes: Jan> FAIL: gdb.base/macscp.exp: info macro __FILE__ before running Jan> FAIL: gdb.base/macscp.exp: print __FILE__ I reproduced it with valgrind and I'm checking in the appended to fix it. Tom 2012-05-21 Tom Tromey * macroexp.c (macro_stringify): Terminate the string. diff --git a/gdb/macroexp.c b/gdb/macroexp.c index 22b904e..fa34311 100644 --- a/gdb/macroexp.c +++ b/gdb/macroexp.c @@ -704,6 +704,7 @@ macro_stringify (const char *str) init_buffer (&buffer, len); stringify (&buffer, str, len); + appendc (&buffer, '\0'); return free_buffer_return_text (&buffer); }