From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25113 invoked by alias); 10 Jul 2012 16:01:27 -0000 Received: (qmail 25104 invoked by uid 22791); 10 Jul 2012 16:01:26 -0000 X-SWARE-Spam-Status: No, hits=-6.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 10 Jul 2012 16:01:10 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q6AG19ks030278 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 10 Jul 2012 12:01:09 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q6AG18nf019390 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Tue, 10 Jul 2012 12:01:08 -0400 From: Tom Tromey To: dje@google.com (Doug Evans) Cc: gdb-patches@sourceware.org Subject: Re: [RFA] symtab.c: Set "first" to zero. References: <20120710003324.100001E13A1@ruffy2.mtv.corp.google.com> Date: Tue, 10 Jul 2012 16:01:00 -0000 In-Reply-To: <20120710003324.100001E13A1@ruffy2.mtv.corp.google.com> (Doug Evans's message of "Mon, 9 Jul 2012 17:33:23 -0700 (PDT)") Message-ID: <87629vip17.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-07/txt/msg00132.txt.bz2 >>>>> "Doug" == Doug Evans writes: Doug> 2012-07-09 Doug Evans Doug> * symtab.c (maybe_add_partial_symtab_filename): Set "first" to zero Doug> after calling filename_seen. Doug> (make_source_files_completion_list): Ditto. I wonder whether filename_seen should clear *first. Tom