From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25527 invoked by alias); 22 Aug 2012 14:21:52 -0000 Received: (qmail 25508 invoked by uid 22791); 22 Aug 2012 14:21:49 -0000 X-SWARE-Spam-Status: No, hits=-6.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS,TW_GF X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 22 Aug 2012 14:21:32 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q7MELWob005386 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 22 Aug 2012 10:21:32 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q7MELUbB014425 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 22 Aug 2012 10:21:31 -0400 From: Tom Tromey To: gdb-patches@sourceware.org Subject: Re: RFC: remove SIGWINCH_HANDLER and SIGWINCH_HANDLER_BODY References: <87obmcuq0i.fsf@fleche.redhat.com> Date: Wed, 22 Aug 2012 14:21:00 -0000 In-Reply-To: <87obmcuq0i.fsf@fleche.redhat.com> (Tom Tromey's message of "Wed, 15 Aug 2012 09:35:41 -0600") Message-ID: <87628buhw5.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-08/txt/msg00611.txt.bz2 >>>>> "Tom" == Tom Tromey writes: Tom> As far as I can tell, nothing ever defines SIGWINCH_HANDLER or Tom> SIGWINCH_HANDLER_BODY, so the code referring to it is dead. Tom> Tested by rebuilding and also grepping to make sure that it isn't Tom> defined somewhere. I also checked Insight. I was about to put this in when I realized I emailed the wrong version of the patch. These macros were documented in gdbint.texinfo, and I had removed that, but not sent it. So, here is the real patch. It needs a doc review. Tom * event-top.c (sigwinch_token, handle_sigwinch): Remove. (async_init_signals): Update. * utils.c (init_page_info): Don't use SIGWINCH_HANDLER. (SIGWINCH_HANDLER_BODY): Remove. * gdbint.texinfo (Host Definition): Remove documentation for SIGWINCH_HANDLER and SIGWINCH_HANDLER_BODY. diff --git a/gdb/doc/gdbint.texinfo b/gdb/doc/gdbint.texinfo index c4c1cc9..0749319 100644 --- a/gdb/doc/gdbint.texinfo +++ b/gdb/doc/gdbint.texinfo @@ -2739,14 +2739,6 @@ are: The default name of @value{GDBN}'s initialization file (normally @file{.gdbinit}). -@item SIGWINCH_HANDLER -If your host defines @code{SIGWINCH}, you can define this to be the name -of a function to be called if @code{SIGWINCH} is received. - -@item SIGWINCH_HANDLER_BODY -Define this to expand into code that will define the function named by -the expansion of @code{SIGWINCH_HANDLER}. - @item CRLF_SOURCE_FILES @cindex DOS text files Define this if host files use @code{\r\n} rather than @code{\n} as a diff --git a/gdb/event-top.c b/gdb/event-top.c index 52e7852..b4a6790 100644 --- a/gdb/event-top.c +++ b/gdb/event-top.c @@ -58,9 +58,6 @@ static void handle_sigquit (int sig); static void handle_sighup (int sig); #endif static void handle_sigfpe (int sig); -#if defined(SIGWINCH) && defined(SIGWINCH_HANDLER) -static void handle_sigwinch (int sig); -#endif /* Functions to be invoked by the event loop in response to signals. */ @@ -134,9 +131,6 @@ void *sighup_token; void *sigquit_token; #endif void *sigfpe_token; -#if defined(SIGWINCH) && defined(SIGWINCH_HANDLER) -void *sigwinch_token; -#endif #ifdef STOP_SIGNAL void *sigtstp_token; #endif @@ -769,11 +763,6 @@ async_init_signals (void) sigfpe_token = create_async_signal_handler (async_float_handler, NULL); -#if defined(SIGWINCH) && defined(SIGWINCH_HANDLER) - signal (SIGWINCH, handle_sigwinch); - sigwinch_token = - create_async_signal_handler (SIGWINCH_HANDLER, NULL); -#endif #ifdef STOP_SIGNAL sigtstp_token = create_async_signal_handler (async_stop_sig, NULL); @@ -950,17 +939,6 @@ async_float_handler (gdb_client_data arg) divide by zero causes this, so "float" is a misnomer. */ error (_("Erroneous arithmetic operation.")); } - -/* Tell the event loop what to do if SIGWINCH is received. - See event-signal.c. */ -#if defined(SIGWINCH) && defined(SIGWINCH_HANDLER) -static void -handle_sigwinch (int sig) -{ - mark_async_signal_handler_wrapper (sigwinch_token); - signal (sig, handle_sigwinch); -} -#endif /* Called by do_setshow_command. */ diff --git a/gdb/utils.c b/gdb/utils.c index 607d7bc..b9e76ab 100644 --- a/gdb/utils.c +++ b/gdb/utils.c @@ -1714,11 +1714,6 @@ init_page_info (void) lines_per_page = UINT_MAX; } - /* FIXME: Get rid of this junk. */ -#if defined(SIGWINCH) && defined(SIGWINCH_HANDLER) - SIGWINCH_HANDLER (SIGWINCH); -#endif - /* If the output is not a terminal, don't paginate it. */ if (!ui_file_isatty (gdb_stdout)) lines_per_page = UINT_MAX; @@ -2743,11 +2738,6 @@ When set, debugging messages will be marked with seconds and microseconds."), &setdebuglist, &showdebuglist); } -/* Machine specific function to handle SIGWINCH signal. */ - -#ifdef SIGWINCH_HANDLER_BODY -SIGWINCH_HANDLER_BODY -#endif /* Print routines to handle variable size regs, etc. */ /* Temporary storage using circular buffer. */ #define NUMCELLS 16