From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-100480-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 31946 invoked by alias); 12 Apr 2013 20:56:57 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 31934 invoked by uid 89); 12 Apr 2013 20:56:57 -0000
X-Spam-SWARE-Status: No, score=-7.7 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.1
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 12 Apr 2013 20:56:57 +0000
Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r3CKusSP022012	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Fri, 12 Apr 2013 16:56:54 -0400
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r3CKuqMK000423	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Fri, 12 Apr 2013 16:56:53 -0400
From: Tom Tromey <tromey@redhat.com>
To: Siva Chandra <sivachandra@google.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [RFC][testsuite] Add option to link testcases with pthreads when using 'prepare_for_testing'
References: <CAGyQ6gyQ8+Txgam=W9+PCdFP1Uy_VHJrK3JM2pL=ZwpYVqjedA@mail.gmail.com>
Date: Mon, 15 Apr 2013 09:22:00 -0000
In-Reply-To: <CAGyQ6gyQ8+Txgam=W9+PCdFP1Uy_VHJrK3JM2pL=ZwpYVqjedA@mail.gmail.com>	(Siva Chandra's message of "Sat, 23 Mar 2013 21:50:49 -0700")
Message-ID: <8761zrfox7.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-SW-Source: 2013-04/txt/msg00406.txt.bz2

>>>>> "Siva" == Siva Chandra <sivachandra@google.com> writes:

Siva> The attached patch allows one to specify an option 'with_pthreads'
Siva> when using 'prepare_for_testing' in tests.  One could call
Siva> gdb_compile_pthreads directly for such a purpose, but I think using
Siva> 'prepare_for_testing' is the suggested approach.  If my understanding
Siva> or approach is wrong here, then what is the best way to make testcases
Siva> to link with pthreads for c++ testcases?

You can use gdb_compile_pthreads and put "c++" in the options.

However, I like your approach.  Actually I wish most of the
gdb_compile_* procs would go away and be replaced by a variant of this
idea.

Siva>         * lib/gdb.exp (build_executable_from_specs): Use
Siva>         gdb_compile_pthreads to compile if option "with_pthreads" is
Siva>         specified.

The intro comment to build_executable_from_specs needs an update to note
that with_pthreads is handled locally.

Siva> +    if { [lsearch -exact $options "with_pthreads"] >= 0 } {    
Siva> +        if  { [gdb_compile_pthreads $objects "${binfile}" executable $options] != "" } {

I wonder if you need to remove with_pthreads from the options here.

Tom