From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8121 invoked by alias); 2 Jul 2013 16:47:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8092 invoked by uid 89); 2 Jul 2013 16:47:30 -0000 X-Spam-SWARE-Status: No, score=-6.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 02 Jul 2013 16:47:29 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r62GlRna003611 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 2 Jul 2013 12:47:27 -0400 Received: from barimba (ovpn-113-102.phx2.redhat.com [10.3.113.102]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r62GlPm8005870 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Tue, 2 Jul 2013 12:47:26 -0400 From: Tom Tromey To: lgustavo@codesourcery.com Cc: "'gdb-patches\@sourceware.org'" Subject: Re: [PATCH, testsuite] Don't run SREC, IHEX and TEKHEX tests for MIPS N64. References: <51D1AD43.3060904@codesourcery.com> Date: Tue, 02 Jul 2013 16:47:00 -0000 In-Reply-To: <51D1AD43.3060904@codesourcery.com> (Luis Machado's message of "Mon, 01 Jul 2013 13:24:35 -0300") Message-ID: <8761wsgb8i.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-07/txt/msg00081.txt.bz2 >>>>> "Luis" == Luis Machado writes: Luis> Skipping this test for MIPS is not the right thing as some ABI's are Luis> 32-bit and so should be tested against the usual set of SREC, IHEX and Luis> TEKHEX formats. Luis> The attached patch checks for the N64 ABI and sets the internal flag Luis> is64bitonly accordingly, skipping the SREC, IHEX and TEKHEX tests. Should this be made more generic? Say, test for "sizeof(&main) != 4"? Tom