From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-103397-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 31840 invoked by alias); 13 Jul 2013 07:22:25 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 31807 invoked by uid 89); 13 Jul 2013 07:22:24 -0000
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,RDNS_NONE,SPF_PASS,TW_FX autolearn=no version=3.3.1
X-Spam-User: qpsmtpd, 2 recipients
Received: from Unknown (HELO mail-wi0-f173.google.com) (209.85.212.173)    by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Sat, 13 Jul 2013 07:22:24 +0000
Received: by mail-wi0-f173.google.com with SMTP id hq4so1370019wib.6        for <multiple recipients>; Sat, 13 Jul 2013 00:22:15 -0700 (PDT)
X-Received: by 10.194.78.42 with SMTP id y10mr25330581wjw.93.1373700135504;        Sat, 13 Jul 2013 00:22:15 -0700 (PDT)
Received: from localhost ([2.26.194.2])        by mx.google.com with ESMTPSA id x2sm7235134wif.3.2013.07.13.00.22.14        for <multiple recipients>        (version=TLSv1.2 cipher=RC4-SHA bits=128/128);        Sat, 13 Jul 2013 00:22:14 -0700 (PDT)
From: Richard Sandiford <rdsandiford@googlemail.com>
To: "Maciej W. Rozycki" <macro@codesourcery.com>
Mail-Followup-To: "Maciej W. Rozycki" <macro@codesourcery.com>,<binutils@sourceware.org>,  <gdb-patches@sourceware.org>, rdsandiford@googlemail.com
Cc: <binutils@sourceware.org>,  <gdb-patches@sourceware.org>
Subject: Re: [PATCH] MIPS: Define descriptive names for GNU attribute values
References: <alpine.DEB.1.10.1307121705400.20590@tp.orcam.me.uk>
Date: Sat, 13 Jul 2013 07:22:00 -0000
In-Reply-To: <alpine.DEB.1.10.1307121705400.20590@tp.orcam.me.uk> (Maciej	W. Rozycki's message of "Fri, 12 Jul 2013 17:23:22 +0100")
Message-ID: <8761we3owq.fsf@talisman.default>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-SW-Source: 2013-07/txt/msg00337.txt.bz2

"Maciej W. Rozycki" <macro@codesourcery.com> writes:
> 2013-07-12  Maciej W. Rozycki  <macro@codesourcery.com>
>
> 	include/elf/
> 	* mips.h (Tag_GNU_MIPS_ABI_FP): Remove comment.
> 	(Val_GNU_MIPS_ABI_FP_ANY, Val_GNU_MIPS_ABI_FP_DOUBLE,
> 	Val_GNU_MIPS_ABI_FP_SINGLE, Val_GNU_MIPS_ABI_FP_SOFT,
> 	Val_GNU_MIPS_ABI_FP_64): New enum.
>
> 	bfd/
> 	* elfxx-mips.c (mips_elf_merge_obj_attributes): Replace hardcoded
> 	magic numbers with enum values.
>
> 	binutils/
> 	* readelf.c (display_mips_gnu_attribute): Replace hardcoded magic
> 	numbers with enum values.
>
> 	gdb/
> 	* mips-tdep.c (mips_gdbarch_init): Replace hardcoded magic
> 	numbers with enum values.

OK.  Nice cleanup, thanks.

Richard