[PATCH v3 02/17] fix some simple thinkos in the test suite

Tom Tromey
2013-10-25T20:21:15Z

This fixes some parallelization thinkos from a while ago. I'm not
sure how the problems ever slipped through. In addition to a thinko
fix in twice.exp, this also finishes fixing it up for parallelization.

~ChangeLog~
2013-10-24 Tom Tromey <tromey@redhat.com>

* gdb.base/gcore-buffer-overflow.exp: Use
standard_output_file, not standard_testfile.
* gdb.base/twice.exp: Use standard_testfile, not
standard_output_file. Use gdb_remote_download.
---
gdb/testsuite/ChangeLog | 7 +++++++
gdb/testsuite/gdb.base/gcore-buffer-overflow.exp | 3 ++-
gdb/testsuite/gdb.base/twice.exp | 4 ++--
3 files changed, 11 insertions(+), 3 deletions(-)

diff --git a/gdb/testsuite/gdb.base/gcore-buffer-overflow.exp b/gdb/testsuite/gdb.base/gcore-buffer-overflow.exp
index 8d0867e..47dccf9 100644
--- a/gdb/testsuite/gdb.base/gcore-buffer-overflow.exp
+++ b/gdb/testsuite/gdb.base/gcore-buffer-overflow.exp
@@ -51,4 +51,5 @@ if { ! [ runto_main ] } then {
return -1
}

-gdb_gcore_cmd [standard_testfile gcore-buffer-overflow.test] "save a corefile"
+gdb_gcore_cmd [standard_output_file gcore-buffer-overflow.test] \
+ "save a corefile"
diff --git a/gdb/testsuite/gdb.base/twice.exp b/gdb/testsuite/gdb.base/twice.exp
index 936ddcb..9e7e334 100644
--- a/gdb/testsuite/gdb.base/twice.exp
+++ b/gdb/testsuite/gdb.base/twice.exp
@@ -14,7 +14,7 @@
# along with this program. If not, see <http://www.gnu.org/licenses/>.

-standard_output_file twice.c
+standard_testfile twice.c
set options debug
lappend options "additional_flags=-I."

@@ -23,7 +23,7 @@ set fileid [open $local_srcfile w]
puts $fileid "#include \"twice.c\""
close $fileid

-remote_download host ${srcdir}/${subdir}/twice.c twice.c
+gdb_remote_download host ${srcdir}/${subdir}/twice.c

if { [gdb_compile $local_srcfile "${binfile}" executable $options] != "" } {
untested twice.exp
--
1.8.1.4