From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5408 invoked by alias); 27 Nov 2013 17:08:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5329 invoked by uid 89); 27 Nov 2013 17:08:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_05,RDNS_NONE,SPF_HELO_PASS,SPF_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 27 Nov 2013 17:08:26 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rARH8Hfh028916 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 27 Nov 2013 12:08:18 -0500 Received: from barimba (ovpn-113-124.phx2.redhat.com [10.3.113.124]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id rARH8EfX029445 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 27 Nov 2013 12:08:14 -0500 From: Tom Tromey To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 4/8] remove some stale FIXMEs References: <1385502587-29757-1-git-send-email-tromey@redhat.com> <1385502587-29757-5-git-send-email-tromey@redhat.com> <5295D6FC.7030508@redhat.com> <87vbzd3nwa.fsf@fleche.redhat.com> Date: Wed, 27 Nov 2013 17:21:00 -0000 In-Reply-To: <87vbzd3nwa.fsf@fleche.redhat.com> (Tom Tromey's message of "Wed, 27 Nov 2013 07:44:21 -0700") Message-ID: <8761rd3h8h.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-11/txt/msg00847.txt.bz2 Tom> I'll fix it. Here's a new version. Tom commit 370f78a0c0bdb770d21abc3dccb61da4ed3574eb Author: Tom Tromey Date: Mon Nov 25 08:47:51 2013 -0700 fix a couple of FIXMEs This fixes a couple of old "32x64" FIXME comments by using paddress with current_gdbarch rather than hex_string and a cast to long. 2013-11-26 Tom Tromey * cli/cli-cmds.c (edit_command): Use paddress, not hex_string. (list_command): Likewise. diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 0bda3bb..d059474 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,10 @@ 2013-11-26 Tom Tromey + * cli/cli-cmds.c (edit_command): Use paddress, not hex_string. + (list_command): Likewise. + +2013-11-26 Tom Tromey + * psymtab.c (allocate_psymtab): Put the filename in the filename bcache. diff --git a/gdb/cli/cli-cmds.c b/gdb/cli/cli-cmds.c index 85f1713..52a6bc9 100644 --- a/gdb/cli/cli-cmds.c +++ b/gdb/cli/cli-cmds.c @@ -817,9 +817,8 @@ edit_command (char *arg, int from_tty) struct gdbarch *gdbarch; if (sal.symtab == 0) - /* FIXME-32x64--assumes sal.pc fits in long. */ error (_("No source file for address %s."), - hex_string ((unsigned long) sal.pc)); + paddress (get_current_arch (), sal.pc)); gdbarch = get_objfile_arch (sal.symtab->objfile); sym = find_pc_function (sal.pc); @@ -982,9 +981,8 @@ list_command (char *arg, int from_tty) struct gdbarch *gdbarch; if (sal.symtab == 0) - /* FIXME-32x64--assumes sal.pc fits in long. */ error (_("No source file for address %s."), - hex_string ((unsigned long) sal.pc)); + paddress (get_current_arch (), sal.pc)); gdbarch = get_objfile_arch (sal.symtab->objfile); sym = find_pc_function (sal.pc);