From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8531 invoked by alias); 21 May 2014 14:14:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8516 invoked by uid 89); 21 May 2014 14:14:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 21 May 2014 14:14:12 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s4LEEBi6005646 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 21 May 2014 10:14:11 -0400 Received: from barimba (ovpn-113-182.phx2.redhat.com [10.3.113.182]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s4LEEAfB028420 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO); Wed, 21 May 2014 10:14:10 -0400 From: Tom Tromey To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: [patch] Fix TLS access for -static -pthread References: <20140410115204.GB16411@host2.jankratochvil.net> <87d2f8trjo.fsf@fleche.redhat.com> <20140521121734.GA14288@host2.jankratochvil.net> Date: Wed, 21 May 2014 14:14:00 -0000 In-Reply-To: <20140521121734.GA14288@host2.jankratochvil.net> (Jan Kratochvil's message of "Wed, 21 May 2014 14:17:34 +0200") Message-ID: <8761kzp6by.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2014-05/txt/msg00482.txt.bz2 Tom> This bit of code (and another like it later on) should have a longer Tom> comment, probably at least including the link above, but also some text Tom> about how this is a hack but why it is ok. Jan> I have put there: Jan> + /* This code path handles the case of -static -pthread executables: Jan> + https://sourceware.org/ml/libc-help/2014-03/msg00024.html Jan> + For older GNU libc r_debug.r_map is NULL. For GNU libc after Jan> + PR libc/16831 due to GDB PR threads/16954 LOAD_MODULE is also NULL. Jan> + The constant number 1 depends on GNU __libc_setup_tls Jan> + initialization of l_tls_modid to 1. */ Thanks, that looks good. Tom