From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12322 invoked by alias); 5 Jul 2014 17:17:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 12223 invoked by uid 89); 5 Jul 2014 17:17:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,UNPARSEABLE_RELAY autolearn=ham version=3.3.2 X-HELO: layla.krisman.be Received: from layla.krisman.be (HELO layla.krisman.be) (176.31.208.35) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Sat, 05 Jul 2014 17:16:58 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (envelope-from ) id 1X3TZI-0001o9-3P; Sat, 05 Jul 2014 19:16:08 +0200 From: Gabriel Krisman Bertazi To: Sergio Durigan Junior Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Fix gdb.fortran/array-element.exp failures. References: <1404453487-20108-1-git-send-email-gabriel@krisman.be> <87zjgobth0.fsf@Argo.krisman.be> Date: Sat, 05 Jul 2014 17:17:00 -0000 In-Reply-To: (Sergio Durigan Junior's message of "Sat, 05 Jul 2014 09:14:16 -0300") Message-ID: <8761jbbu6l.fsf@Argo.krisman.be> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-IsSubscribed: yes X-SW-Source: 2014-07/txt/msg00100.txt.bz2 --=-=-= Content-Type: text/plain Content-length: 398 Sergio Durigan Junior writes: > Thanks! It is missing a (new) ChangeLog entry; other than that, I > believe it is fine to be applied. > Sorry, I missed it. Here follows the patch and the updated changelog. 2014-07-05 Gabriel Krisman Bertazi * array-element.exp: Remove wrong "continue" command that caused test to fail and simplifies test case. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=fortran_test.patch Content-length: 974 diff --git a/gdb/testsuite/gdb.fortran/array-element.exp b/gdb/testsuite/gdb.fortran/array-element.exp index 579db03..1ac3623 100644 --- a/gdb/testsuite/gdb.fortran/array-element.exp +++ b/gdb/testsuite/gdb.fortran/array-element.exp @@ -31,18 +31,9 @@ if ![runto sub_] then { continue } -set bp_location [gdb_get_line_number "continue"] -gdb_test "break $bp_location" \ - "Breakpoint.*at.* file .*$srcfile, line $bp_location\\." \ - "breakpoint at continue" - -gdb_test "continue" \ - "Continuing\\..*Breakpoint.*" \ - "continue to breakpoint" -gdb_test "print a(1)" ".*1 = 1.*" "print the first element of array a" +gdb_breakpoint [gdb_get_line_number "continue"] +gdb_continue_to_breakpoint "continue" -gdb_test "continue" \ - "Continuing\\..*Breakpoint.*" \ - "continue to breakpoint once again" +gdb_test "print a(1)" ".*1 = 1.*" "print the first element of array a" gdb_test "print a(2)" ".*2 = 2.*" "print the second element of array a" --=-=-= Content-Type: text/plain Content-length: 29 -- Gabriel Krisman Bertazi --=-=-=--