From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18055 invoked by alias); 5 Nov 2014 06:37:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 18043 invoked by uid 89); 5 Nov 2014 06:37:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 05 Nov 2014 06:37:30 +0000 Received: from svr-orw-fem-06.mgc.mentorg.com ([147.34.97.120]) by relay1.mentorg.com with esmtp id 1XluDf-0003kc-2L from Yao_Qi@mentor.com ; Tue, 04 Nov 2014 22:37:27 -0800 Received: from GreenOnly (147.34.91.1) by SVR-ORW-FEM-06.mgc.mentorg.com (147.34.97.120) with Microsoft SMTP Server id 14.3.181.6; Tue, 4 Nov 2014 22:37:26 -0800 From: Yao Qi To: Pedro Alves CC: Subject: Re: [PATCH 2/3] make "permanent breakpoints" per location and disableable References: <1415127790-15091-1-git-send-email-palves@redhat.com> <1415127790-15091-3-git-send-email-palves@redhat.com> Date: Wed, 05 Nov 2014 06:37:00 -0000 In-Reply-To: <1415127790-15091-3-git-send-email-palves@redhat.com> (Pedro Alves's message of "Tue, 4 Nov 2014 19:03:09 +0000") Message-ID: <8761eu8863.fsf@codesourcery.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2014-11/txt/msg00097.txt.bz2 Pedro Alves writes: Hi Pedro, I go through this patch, and don't see anything wrong except this below, > diff --git a/gdb/breakpoint.h b/gdb/breakpoint.h > index 118a37f..c383cd4 100644 > --- a/gdb/breakpoint.h > +++ b/gdb/breakpoint.h > @@ -193,12 +193,6 @@ enum enable_state > automatically enabled and reset when the > call "lands" (either completes, or stops > at another eventpoint). */ > - bp_permanent /* There is a breakpoint instruction > - hard-wired into the target's code. Don't > - try to write another breakpoint > - instruction on top of it, or restore its > - value. Step over it using the > - architecture's SKIP_INSN macro. */ > }; This causes a compilation error in guile/scm-breakpoint.c where bp_permanent is in use. ../../../git/gdb/guile/scm-breakpoint.c: In function =E2=80=98bpscm_enable_= state_to_string=E2=80=99: ../../../git/gdb/guile/scm-breakpoint.c:154:10: error: =E2=80=98bp_permanen= t=E2=80=99 undeclared (first use in this function) case bp_permanent: return "permanent"; static const char * bpscm_enable_state_to_string (enum enable_state enable_state) { switch (enable_state) { case bp_disabled: return "disabled"; case bp_enabled: return "enabled"; case bp_call_disabled: return "call_disabled"; case bp_permanent: return "permanent"; ^^^^^^^^^^^^ default: return "unknown"; } } --=20 Yao (=E9=BD=90=E5=B0=A7)