From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 86834 invoked by alias); 27 Sep 2016 21:51:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 86810 invoked by uid 89); 27 Sep 2016 21:51:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=qiyaoltcgmailcom, qiyaoltc@gmail.com, U*qiyaoltc, sk:qiyaolt X-HELO: gproxy8-pub.mail.unifiedlayer.com Received: from gproxy8-pub.mail.unifiedlayer.com (HELO gproxy8-pub.mail.unifiedlayer.com) (67.222.33.93) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with SMTP; Tue, 27 Sep 2016 21:51:08 +0000 Received: (qmail 18280 invoked by uid 0); 27 Sep 2016 21:51:06 -0000 Received: from unknown (HELO cmgw3) (10.0.90.84) by gproxy8.mail.unifiedlayer.com with SMTP; 27 Sep 2016 21:51:06 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by cmgw3 with id olr21t01M2f2jeq01lr5gE; Tue, 27 Sep 2016 15:51:06 -0600 X-Authority-Analysis: v=2.1 cv=aaryw3Yt c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=GW1xBdLrtEIA:10 a=pGLkceISAAAA:8 a=hMpQOmkxnmKsXHoX3BgA:9 a=6kGIvZw6iX1k4Y-7sg4_:22 Received: from 71-218-192-86.hlrn.qwest.net ([71.218.192.86]:47216 helo=pokyo) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.86_1) (envelope-from ) id 1bozdn-00016K-E2; Tue, 27 Sep 2016 15:10:15 -0600 From: Tom Tromey To: Yao Qi Cc: Tom Tromey , "gdb-patches\@sourceware.org" Subject: Re: [RFA 1/3] Fix "fall through" comments References: <1475000192-8789-1-git-send-email-tom@tromey.com> <1475000192-8789-2-git-send-email-tom@tromey.com> Date: Tue, 27 Sep 2016 21:53:00 -0000 In-Reply-To: (Yao Qi's message of "Tue, 27 Sep 2016 22:03:40 +0100") Message-ID: <8760phcamm.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Exim-ID: 1bozdn-00016K-E2 X-Source-Sender: 71-218-192-86.hlrn.qwest.net (pokyo) [71.218.192.86]:47216 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-SW-Source: 2016-09/txt/msg00386.txt.bz2 >>>>> "Yao" == Yao Qi writes: Yao> clang has -Wimplicit-fallthrough as well, but warnings are suppressed in Yao> a different way. Do we need to suppress warnings generated by both gcc Yao> and clang? On my machine, clang won't build gdb. From memory there was at least some issue compiling .c files in c++ mode, but I think there were other problems as well. If clang support is desired, then yes, the correct approach is to replace the fall-through comments with a new attribute. Tom