From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 57300 invoked by alias); 16 Nov 2016 23:18:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 57287 invoked by uid 89); 16 Nov 2016 23:18:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=noexcept X-HELO: gproxy7-pub.mail.unifiedlayer.com Received: from gproxy7-pub.mail.unifiedlayer.com (HELO gproxy7-pub.mail.unifiedlayer.com) (70.40.196.235) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with SMTP; Wed, 16 Nov 2016 23:18:20 +0000 Received: (qmail 17429 invoked by uid 0); 16 Nov 2016 23:18:19 -0000 Received: from unknown (HELO CMOut01) (10.0.90.82) by gproxy7.mail.unifiedlayer.com with SMTP; 16 Nov 2016 23:18:19 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by CMOut01 with id 8nJE1u00F2f2jeq01nJHEZ; Wed, 16 Nov 2016 16:18:17 -0700 X-Authority-Analysis: v=2.1 cv=QtDNgzCd c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=L24OOQBejmoA:10 a=20KFwNOVAAAA:8 a=Pl7MrANX7jLexMtc8AkA:9 a=e_O65bzb51kRm2y5VmPK:22 Received: from 97-118-168-190.hlrn.qwest.net ([97.118.168.190]:59664 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.86_1) (envelope-from ) id 1c79T5-00009y-JP; Wed, 16 Nov 2016 16:18:15 -0700 From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA 01/14] Introduce py-ref.h References: <1478497656-11832-1-git-send-email-tom@tromey.com> <1478497656-11832-2-git-send-email-tom@tromey.com> <7df8b22f-cd05-c0d6-5ede-e9dc29bca6e2@redhat.com> <8760nsiozp.fsf@tromey.com> Date: Wed, 16 Nov 2016 23:18:00 -0000 In-Reply-To: (Pedro Alves's message of "Tue, 15 Nov 2016 14:32:12 +0000") Message-ID: <8760nnqaix.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Exim-ID: 1c79T5-00009y-JP X-Source-Sender: 97-118-168-190.hlrn.qwest.net (bapiya) [97.118.168.190]:59664 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-SW-Source: 2016-11/txt/msg00464.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> Since there's no need to worry about noexcept garantees here Pedro> (destructing a gdbpy_ref can't throw), I'd rather that Pedro> move would not be implemented as a swap, as that extends the Pedro> lifetime of m_obj in OTHER. [...] Pedro> Or perhaps simpler, go with something like what you had in the Pedro> first version: I made this change. Pedro> But add a "if (this != &other)" check. I'd tweak it to be Pedro> in terms of reset() while at it: I also changed the other operator= to use reset(), and I changed the code to use Py_XINCREF rather than a NULL check. Tom