From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [RFA 2/2] C++-ify break-catch-throw
Date: Mon, 05 Jun 2017 19:10:00 -0000 [thread overview]
Message-ID: <8760ga6yjg.fsf@pokyo> (raw)
In-Reply-To: <2ab77f7b8d7bd7454be1fe232e2b28fd@polymtl.ca> (Simon Marchi's message of "Mon, 05 Jun 2017 10:54:01 +0200")
>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:
Simon> From what I understand, we were freeing the regex with regfree, but we
Simon> weren't freeing the regex_t object, which is allocated separately, is
Simon> that right?
Yes, I think that's a leak in the current code.
Tom
next prev parent reply other threads:[~2017-06-05 19:10 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-04 22:54 [RFA 0/2] C++-ify some breakpoint subclasses a bit more Tom Tromey
2017-06-04 22:54 ` [RFA 1/2] C++-ify break-catch-sig Tom Tromey
2017-06-05 8:43 ` Simon Marchi
2017-06-05 13:13 ` Tom Tromey
2017-06-05 13:53 ` Tom Tromey
2017-06-04 22:54 ` [RFA 2/2] C++-ify break-catch-throw Tom Tromey
2017-06-05 8:54 ` Simon Marchi
2017-06-05 19:10 ` Tom Tromey [this message]
2017-06-05 10:21 ` Pedro Alves
2017-06-05 10:33 ` Pedro Alves
2017-06-05 10:36 ` Pedro Alves
2017-06-05 12:29 ` Pedro Alves
2017-06-05 12:32 ` Pedro Alves
2017-06-05 19:27 ` Tom Tromey
2017-06-06 16:22 ` Pedro Alves
2017-06-07 12:38 ` Tom Tromey
2017-06-07 13:40 ` [pushed] Introduce compiled_regex, eliminate make_regfree_cleanup (Re: [RFA 2/2] C++-ify break-catch-throw) Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8760ga6yjg.fsf@pokyo \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox