From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 112067 invoked by alias); 30 Jun 2017 11:16:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 111642 invoked by uid 89); 30 Jun 2017 11:16:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.6 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,TRACKER_ID autolearn=no version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 30 Jun 2017 11:16:11 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2B0B283F3E; Fri, 30 Jun 2017 11:16:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 2B0B283F3E Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=sergiodj@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 2B0B283F3E Received: from localhost (unused-10-15-17-193.yyz.redhat.com [10.15.17.193]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F3DC07C13F; Fri, 30 Jun 2017 11:16:09 +0000 (UTC) From: Sergio Durigan Junior To: Simon Marchi Cc: GDB Patches , Jerome Guitton Subject: Re: [PATCH] PR cli/21688: Fix multi-line/inline command differentiation References: <20170629020527.468-1-sergiodj@redhat.com> <90d0a1563dea6893b5dbcd8df19d0285@polymtl.ca> <87d19mmv7q.fsf@redhat.com> <87fueil9jx.fsf@redhat.com> <725a3a1dc21cf9ad38100468caa83d67@polymtl.ca> Date: Fri, 30 Jun 2017 11:16:00 -0000 In-Reply-To: <725a3a1dc21cf9ad38100468caa83d67@polymtl.ca> (Simon Marchi's message of "Fri, 30 Jun 2017 09:00:36 +0200") Message-ID: <8760fdlo92.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2017-06/txt/msg00818.txt.bz2 On Friday, June 30 2017, Simon Marchi wrote: > On 2017-06-30 00:21, Sergio Durigan Junior wrote: >> On Thursday, June 29 2017, Simon Marchi wrote: >> >>> On 2017-06-29 21:48, Sergio Durigan Junior wrote: >>>> On Thursday, June 29 2017, Simon Marchi wrote: >>>>> Another (maybe simpler) way would be to check >>>>> >>>>> else if (command_name_equals (cmd, "python") && *cmd_name == '\0') >>>>> >>>>> It's not clear when expressed like this though because cmd_name >>>>> is not >>>>> well named at this point (it points just after the command name). >>>> >>>> Hm, right. Would you prefer this way instead? I don't have a strong >>>> opinion on this. >>> >>> My opinion is the solution with the least code is probably best, if >>> they are equivalent otherwise, but I don't really mind. It's just a >>> suggestion. >> >> Right. I did some more tests here, and unfortunately your solution >> doesn't work for all cases. For example, if the user puts trailing >> whitespace on the command name (like "python "), *cmd_name will >> point to >> a whitespace after the call to lookup_cmd_1. > > Ah, I got confused because there's some code that strips trailing > whitespaces, but it only set p_end, it doesn't modify the string. Yeah. Another option would be to advance cmd_name until there is no more whitespace-like char. Anyway... >> So here's second version of the patch, with the fixes you requested >> except the one above. WDYT? > > That LGTM. Thanks, pushed. 51ed89aa0dce3db46561235efdc4bbc0661bcf37 -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/