From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 130505 invoked by alias); 22 Jul 2017 03:53:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 129791 invoked by uid 89); 22 Jul 2017 03:52:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gproxy5.mail.unifiedlayer.com Received: from gproxy5-pub.mail.unifiedlayer.com (HELO gproxy5.mail.unifiedlayer.com) (67.222.38.55) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 22 Jul 2017 03:52:55 +0000 Received: from cmgw3 (unknown [10.0.90.84]) by gproxy5.mail.unifiedlayer.com (Postfix) with ESMTP id 9559F1406F1 for ; Fri, 21 Jul 2017 21:52:53 -0600 (MDT) Received: from box522.bluehost.com ([74.220.219.122]) by cmgw3 with id nfsq1v0082f2jeq01fstVH; Fri, 21 Jul 2017 21:52:53 -0600 X-Authority-Analysis: v=2.2 cv=a95AzQaF c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=G3gG6ho9WtcA:10 a=20KFwNOVAAAA:8 a=Co2GJrkv3c1ktuKTqfEA:9 Received: from 174-29-39-24.hlrn.qwest.net ([174.29.39.24]:59754 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from ) id 1dYlTG-003kuF-17; Fri, 21 Jul 2017 21:52:50 -0600 From: Tom Tromey To: Sergio Durigan Junior Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA v2 1/4] C++-ify break-catch-sig References: <20170719203225.6714-1-tom@tromey.com> <20170719203225.6714-2-tom@tromey.com> <87d18vkmdb.fsf@redhat.com> Date: Sat, 22 Jul 2017 03:53:00 -0000 In-Reply-To: <87d18vkmdb.fsf@redhat.com> (Sergio Durigan Junior's message of "Thu, 20 Jul 2017 14:13:20 -0400") Message-ID: <8760elm8l0.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Exim-ID: 1dYlTG-003kuF-17 X-Source-Sender: 174-29-39-24.hlrn.qwest.net (bapiya) [174.29.39.24]:59754 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-Local-Domain: yes X-SW-Source: 2017-07/txt/msg00328.txt.bz2 >>>>> "Sergio" == Sergio Durigan Junior writes: >> - if (c->signals_to_be_caught) >> + if (!c->signals_to_be_caught.empty ()) >> { >> - int i; >> - gdb_signal_type iter; >> - >> - for (i = 0; >> - VEC_iterate (gdb_signal_type, c->signals_to_be_caught, i, iter); >> - i++) >> + for (gdb_signal iter : c->signals_to_be_caught) >> if (signal_number == iter) >> return 1; >> /* Not the same. */ >> - gdb_assert (!iter); Sergio> I don't really understand what this assert was checking. In what Sergio> situation would iter == 0? Yeah, I don't know either. Tom