From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 86823 invoked by alias); 23 Sep 2017 04:32:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 86811 invoked by uid 89); 23 Sep 2017 04:32:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=Hx-languages-length:692 X-HELO: gproxy7-pub.mail.unifiedlayer.com Received: from gproxy7-pub.mail.unifiedlayer.com (HELO gproxy7-pub.mail.unifiedlayer.com) (70.40.196.235) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 23 Sep 2017 04:32:35 +0000 Received: from cmgw4 (unknown [10.0.90.85]) by gproxy7.mail.unifiedlayer.com (Postfix) with ESMTP id D5A1D215C74 for ; Fri, 22 Sep 2017 22:32:33 -0600 (MDT) Received: from box522.bluehost.com ([74.220.219.122]) by cmgw4 with id CsYW1w06C2f2jeq01sYZhT; Fri, 22 Sep 2017 22:32:33 -0600 X-Authority-Analysis: v=2.2 cv=OZLoNlbY c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=2JCJgTwv5E4A:10 a=20KFwNOVAAAA:8 a=vp9aiHG-oySGSdfGsV4A:9 Received: from 75-166-76-94.hlrn.qwest.net ([75.166.76.94]:39178 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from ) id 1dvc7C-002oNW-Ll; Fri, 22 Sep 2017 22:32:30 -0600 From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA 35/67] Constify commands maint.c, plus maintenance_print_type References: <20170921051023.19023-1-tom@tromey.com> <20170921051023.19023-36-tom@tromey.com> Date: Sat, 23 Sep 2017 04:32:00 -0000 In-Reply-To: (Pedro Alves's message of "Thu, 21 Sep 2017 11:06:51 +0100") Message-ID: <8760caghlt.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Exim-ID: 1dvc7C-002oNW-Ll X-Source-Sender: 75-166-76-94.hlrn.qwest.net (bapiya) [75.166.76.94]:39178 X-Source-Auth: tom+tromey.com X-Email-Count: 22 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-Local-Domain: yes X-SW-Source: 2017-09/txt/msg00725.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> On 09/21/2017 06:09 AM, Tom Tromey wrote: >> >> @@ -591,8 +583,7 @@ maintenance_do_deprecate (char *text, int deprecate) >> if (end_ptr != NULL) >> { >> len = end_ptr - start_ptr; >> - start_ptr[len] = '\0'; >> - replacement = xstrdup (start_ptr); >> + replacement = savestring (start_ptr, len); >> } Pedro> This looks like another "command repeat" bug fix, right? Yay! :-) I hadn't noticed :) Pedro> (Please mention it in the commit log.) I added this to the commit message: In addition to the constification, this fixes a command-repeat bug. Tom