Re: [RFA 4/7] Use ui_out_emit_tuple in disasm.c

Simon Marchi
2017-10-12T15:37:13Z

On 2017-09-09 02:35 PM, Simon Marchi wrote:
> On 2017-09-09 17:35, Tom Tromey wrote:
>> This changes one spot in disasm.c to use ui_out_emit_tuple.Â  This
>> patch required a large reindentation, so I've separated it out.
>
> "git show -w" does wonders!Â  The hard part is figuring out if there's something else in this big function using cleanups (and therefore if the cleanup variable should be kept).
>
> Anyway, this LGTM.
>
> Simon
>

I found a regression, bisect pointed to this patch (which makes sense).

1. Run "disassemble /s" on a small enough terminal so that pagination kicks in.
2. Type q <return> to quit pagination.

I get:

---Type <return> to continue, or q <return> to quit---q
/home/emaisin/src/binutils-gdb/gdb/ui-out.c:344: internal-error: void ui_out::pop_level(ui_out_type): Assertion `current_level ()->type () == type' failed.
A problem internal to GDB has been detected,
further debugging may prove unreliable.
Quit this debugging session? (y or n)

Simon