Re: [RFA 2/7] Remove make_cleanup_ui_out_table_begin_end

Simon Marchi
2017-09-09T18:22:58Z

On 2017-09-09 18:02, Tom Tromey wrote:
> I forgot to mention something I had meant to mention when submitting
> this series:
>
> Tom> * spu-tdep.c (info_spu_mailbox_list): Use ui_out_emit_table.
> Tom> (info_spu_dma_cmdlist): Likewise.
> [..]
> Tom> * darwin-nat-info.c (darwin_debug_regions_recurse): Use
> Tom> ui_out_emit_table.
>
> I don't have any way to test these, or even compile the darwin patch.
> So this requires extra careful review at least, or someone to volunteer
> to try them out.
>
> It would be very nice to have a darwin builder hooked up to the
> buildbot. I'm not sure how practical this is ... there are so many
> Macs
> around Moz that maybe I could acquire one somehow, but I don't know
> that I could host it anywhere.

The patch LGTM.

I built-tested your series on a Mac, it builds fine (if we ignore all
the current hurdles to get it to build). Now when I try actually
running, I get this:

(gdb) r
Starting program: /Users/simark/build/binutils-gdb/gdb/test_clang
[New Thread 0x1503 of process 79554]
[New Thread 0x1803 of process 79554]
Warning:
Cannot insert breakpoint -1.
Cannot access memory at address 0xeb19

Command aborted.

But it also does that before your patch.

Simon