From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 69673 invoked by alias); 3 Nov 2017 17:07:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 69660 invoked by uid 89); 3 Nov 2017 17:07:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway30.websitewelcome.com Received: from gateway30.websitewelcome.com (HELO gateway30.websitewelcome.com) (192.185.192.34) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 03 Nov 2017 17:07:55 +0000 Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway30.websitewelcome.com (Postfix) with ESMTP id E45661485B for ; Fri, 3 Nov 2017 12:07:53 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id AfRheF8nUc72gAfRheDAlm; Fri, 03 Nov 2017 12:07:53 -0500 Received: from 71-218-90-63.hlrn.qwest.net ([71.218.90.63]:35572 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1eAfRh-000u50-Ko; Fri, 03 Nov 2017 12:07:53 -0500 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA 09/13] Use gdb::def_vector in ppc-linux-tdep.c References: <20171102223612.3642-1-tom@tromey.com> <20171102223612.3642-10-tom@tromey.com> Date: Fri, 03 Nov 2017 17:07:00 -0000 In-Reply-To: (Simon Marchi's message of "Thu, 02 Nov 2017 21:31:30 -0400") Message-ID: <8760aruw7r.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Source-L: No X-Exim-ID: 1eAfRh-000u50-Ko X-Source-Sender: 71-218-90-63.hlrn.qwest.net (bapiya) [71.218.90.63]:35572 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-SW-Source: 2017-11/txt/msg00084.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> I would prefer if you used gdb::byte_vector, so it's consistent across Simon> the codebase. ... Simon> You can skip the ret variable. I made these changes. Tom