Re: [PATCH v2] Add support for the --readnever command-line option (DWARF only)

Pedro Alves
2017-11-29T12:23:08Z

On 11/29/2017 12:59 AM, Sergio Durigan Junior wrote:
> On Monday, November 27 2017, Pedro Alves wrote:

>> It's really not a bit deal, but to me it'd be more
>> consistent have all readers do the same logically.
>
> Understood. I switched the logic and now I'm doing all the work on
> elf_symfile_read (and consequently dwarf2_has_info, which now is the
> right place to put the checks on).
>
> I wasn't sure if I should modify other *_symfile_read functions to obey
> the setting, so I left them alone.

Surely you should? You'll need to modify coffread.c and xcoffread.c
accordingly. In the earlier iteration you were changing coffstab_build_psymtabs,
for example. Basically you're moving checks to the callers instead, so
you should end up with roughly the same number of checks as before, not fewer.
At least logically. They'll just be in different places.

Thanks,
Pedro Alves