From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 130024 invoked by alias); 1 May 2018 05:09:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 128141 invoked by uid 89); 1 May 2018 05:05:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=unavailable version=3.3.2 spammy=robertson, Robertson, 23124, dan X-HELO: gateway33.websitewelcome.com Received: from gateway33.websitewelcome.com (HELO gateway33.websitewelcome.com) (192.185.145.87) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 01 May 2018 05:04:45 +0000 Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway33.websitewelcome.com (Postfix) with ESMTP id 22D9AC5BCE for ; Tue, 1 May 2018 00:04:43 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id DNT1fzlK8QUwqDNT1fjeZF; Tue, 01 May 2018 00:04:43 -0500 X-Authority-Reason: nr=8 Received: from 97-122-176-117.hlrn.qwest.net ([97.122.176.117]:55508 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1fDNT0-001dt6-Sv; Tue, 01 May 2018 00:04:42 -0500 From: Tom Tromey To: Dan Robertson Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH] bug 23124: rust - Fix null deref when casting References: <20180428032443.GA1869@tomyris> <87fu3e7jtp.fsf@tromey.com> <20180429161452.GA19936@tomyris> Date: Tue, 01 May 2018 05:09:00 -0000 In-Reply-To: <20180429161452.GA19936@tomyris> (Dan Robertson's message of "Sun, 29 Apr 2018 16:14:52 +0000") Message-ID: <8760486k5y.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Source-L: No X-Exim-ID: 1fDNT0-001dt6-Sv X-Source-Sender: 97-122-176-117.hlrn.qwest.net (bapiya) [97.122.176.117]:55508 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-SW-Source: 2018-05/txt/msg00002.txt.bz2 >>>>> "Dan" == Dan Robertson writes: Dan> Thanks for the critiques! Attached an updated patch. Added the minimal Dan> repro listed in the bug and a simple function pointer example to Dan> gdb.rust/expr.exp. I also added ChangeLog entries and updated the change to Dan> align with the gdb code standards. Thanks once again. I'm pushing this now. I slightly reformatted the ChangeLog since one line was too long. Tom