From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 128343 invoked by alias); 8 Jul 2018 16:35:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 128329 invoked by uid 89); 8 Jul 2018 16:35:23 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway30.websitewelcome.com Received: from gateway30.websitewelcome.com (HELO gateway30.websitewelcome.com) (192.185.145.3) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 08 Jul 2018 16:35:22 +0000 Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway30.websitewelcome.com (Postfix) with ESMTP id C7E1A6456 for ; Sun, 8 Jul 2018 11:35:20 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id cCedfFNx4PvAdcCedfMKnb; Sun, 08 Jul 2018 11:35:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=lurAqATsPyxEpQjIJj+nscG8MeVQTQ2oF9ZztZEe/k0=; b=sDCxP8Ny6nT71A2o91Yk7/ujVL JNuqmBkaSn7fdFuC8fCqxex8uVDtwddutst3D/dj7rtaGBc6jLAlGC6QMdgyqVzRbqQCPlUbbqX/s h22mshFGFVkeZq3yXYbrQ2bqQ; Received: from 75-166-85-72.hlrn.qwest.net ([75.166.85.72]:42992 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fcCec-001T3u-V6; Sun, 08 Jul 2018 11:35:19 -0500 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA 05/42] Move pending_macros to buildsym_compunit References: <20180523045851.11660-1-tom@tromey.com> <20180523045851.11660-6-tom@tromey.com> <97a59543-69e0-e330-61f2-f8bd64eaf4ce@simark.ca> Date: Sun, 08 Jul 2018 16:35:00 -0000 In-Reply-To: <97a59543-69e0-e330-61f2-f8bd64eaf4ce@simark.ca> (Simon Marchi's message of "Sat, 7 Jul 2018 11:41:34 -0400") Message-ID: <87601p65yy.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-07/txt/msg00188.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> On 2018-05-23 12:58 AM, Tom Tromey wrote: >> This moves the pending_macros global into buildsym_compunit. Simon> LGTM. As in the other patch, I would like it if the new fields Simon> were private though. Simon> The only access of m_pending_macros outside the class is to check if Simon> the macro table is instantiated. So it could be replaced with this Simon> method: Simon> bool has_macro_table () const Simon> { return m_pending_macros != nullptr; } In the end the members are all private, and nothing outside the class refers to this member directly. I didn't look to see where this reference occurred at this point in the series, but maybe augment_type_symtab, which ends up as a method of buildsym_compunit? Anyway I think the final result should be to your liking. Tom