From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 47435 invoked by alias); 15 Jul 2018 17:44:08 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 47410 invoked by uid 89); 15 Jul 2018 17:44:07 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=sk:buildsy X-HELO: gateway20.websitewelcome.com Received: from gateway20.websitewelcome.com (HELO gateway20.websitewelcome.com) (192.185.64.36) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 15 Jul 2018 17:44:06 +0000 Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway20.websitewelcome.com (Postfix) with ESMTP id 72CA5400CE512 for ; Sun, 15 Jul 2018 12:44:04 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id el40fD22479N3el40fZr32; Sun, 15 Jul 2018 12:44:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=RAlYsAHlQ/e3/o68GkESe6/ry2HC8c9i+pcCJVsbn6I=; b=lJ8bYtUj5Ah7JpQN/qKwvNpVMD uG9v0ghU//f+TC0ELTsjjIjvnED59fjVW4VTKYFduZOL0UNVX68tg5H28XfSF997SgdfPhDEtlRUI gQkQcfpxAMaWFo5CGtcV58DVV; Received: from 75-166-85-72.hlrn.qwest.net ([75.166.85.72]:36030 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fel40-000ZVx-8B; Sun, 15 Jul 2018 12:44:04 -0500 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA 29/42] Move the symbol lists to buildsym_compunit References: <20180523045851.11660-1-tom@tromey.com> <20180523045851.11660-30-tom@tromey.com> <362705eb-9df0-3e02-ce2b-e5bb3cf5b207@simark.ca> Date: Sun, 15 Jul 2018 17:44:00 -0000 In-Reply-To: <362705eb-9df0-3e02-ce2b-e5bb3cf5b207@simark.ca> (Simon Marchi's message of "Mon, 9 Jul 2018 23:38:40 -0400") Message-ID: <87601g9yxo.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-07/txt/msg00465.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> I find it a bit odd to use get_file_symbols () in the "if" but Simon> buildsym_compunit-> m_file_symbols later. I guess it would make Simon> sense for what will eventually become a method of buildsym_compunit Simon> to access the field directly. Simon> The same occurs at different places, with different fields. I fixed these spots up. Tom