From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 121348 invoked by alias); 16 Jul 2018 15:34:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 121337 invoked by uid 89); 16 Jul 2018 15:34:27 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:429, HTo:U*palves X-HELO: gateway30.websitewelcome.com Received: from gateway30.websitewelcome.com (HELO gateway30.websitewelcome.com) (192.185.149.4) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 16 Jul 2018 15:34:25 +0000 Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway30.websitewelcome.com (Postfix) with ESMTP id 7020814E88 for ; Mon, 16 Jul 2018 10:34:24 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id f5W4ftG2YSjJAf5W4fgVr0; Mon, 16 Jul 2018 10:34:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=24IgC16cYGflc7YXejaueHsdI9PH9hYp2PeZ6gYXhH0=; b=MFDTEIHwGULdlZukQAfeZCdJo/ rT7iXpOQUn87/0dfu7R2un+769YTXqS2F+apoSVH6Ll6y1Mvz85nbf4zHnTs+vFDTJeDOki6h6xHr 6xCE7dhnPl1UsCQcc7XrYqNtm; Received: from 75-166-85-72.hlrn.qwest.net ([75.166.85.72]:38224 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1ff5W4-000DQ5-6a; Mon, 16 Jul 2018 10:34:24 -0500 From: Tom Tromey To: Pedro Alves Cc: Simon Marchi , Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA 10/13] Remove unused declaration from value.c References: <20180712205208.32646-1-tom@tromey.com> <20180712205208.32646-11-tom@tromey.com> <97a938d0-3cf4-dc2a-b572-6e55b824cf98@simark.ca> <877elyc11j.fsf@tromey.com> <53ef4f69-ce98-a6e6-50b9-34b449b03a9e@redhat.com> Date: Mon, 16 Jul 2018 15:34:00 -0000 In-Reply-To: <53ef4f69-ce98-a6e6-50b9-34b449b03a9e@redhat.com> (Pedro Alves's message of "Mon, 16 Jul 2018 15:01:58 +0100") Message-ID: <87601f8a9s.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SW-Source: 2018-07/txt/msg00483.txt.bz2 >>>>> "Pedro" =3D=3D Pedro Alves writes: Simon> Then my opinion would be to check if removing it causes any test Simon> failure.=C2=A0 If not, I'd remove it (in its own commit such as this Simon> patch is good, so it's easy to bisect if needed). Pedro> Agreed. If/when we find out it was needed, we can add Pedro> a testcase then. I've made this change. Tom