From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 95550 invoked by alias); 17 Jul 2018 19:11:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 95527 invoked by uid 89); 17 Jul 2018 19:11:02 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway30.websitewelcome.com Received: from gateway30.websitewelcome.com (HELO gateway30.websitewelcome.com) (192.185.145.3) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 17 Jul 2018 19:11:00 +0000 Received: from cm15.websitewelcome.com (cm15.websitewelcome.com [100.42.49.9]) by gateway30.websitewelcome.com (Postfix) with ESMTP id 0124714E9B for ; Tue, 17 Jul 2018 14:10:59 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id fVMffDOWUbXuJfVMzfLFoA; Tue, 17 Jul 2018 14:10:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Bm/oCeu7e7+dyq3TOxR0vzIlZRgRum3Ayxgsne25en0=; b=uSVbOKebiTJNgHv+RhemynfH22 /rPZwNLoID6XZnec7Ukhk//j4Onqc3oEH5bGc0KHSJq37dcqtsvvDj6NOtUO8ox6dXbhyXpki8Om+ GJ4e8AoWGkoMoPouOGp0+ZVOZ; Received: from 75-166-85-72.hlrn.qwest.net ([75.166.85.72]:47746 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1ffVMe-0011Qz-QQ; Tue, 17 Jul 2018 14:10:24 -0500 From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA 2/4] Change gdbscm_exception_message_to_string to return a unique_xmalloc_ptr References: <20180527152009.4228-1-tom@tromey.com> <20180527152009.4228-3-tom@tromey.com> <4f3db9e6-4c5a-c29c-46ab-8ce6e1032b3a@redhat.com> Date: Tue, 17 Jul 2018 19:11:00 -0000 In-Reply-To: <4f3db9e6-4c5a-c29c-46ab-8ce6e1032b3a@redhat.com> (Pedro Alves's message of "Tue, 17 Jul 2018 14:08:34 +0100") Message-ID: <87601dznj3.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-07/txt/msg00530.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: >> gdbscm_print_exception_message (port, SCM_BOOL_F, key, args); >> - result = gdbscm_scm_to_c_string (scm_get_output_string (port)); >> + gdb::unique_xmalloc_ptr result >> + (gdbscm_scm_to_c_string (scm_get_output_string (port))); >> scm_close_port (port); >> - >> return result; >> } Pedro> Did you try making gdbscm_scm_to_c_string return a unique_ptr too? Yes, but this runs into the use of GDBSCM_HANDLE_GDB_EXCEPTION_WITH_CLEANUPS in (at least) gdbscm_value_field. I haven't looked into what to do about this. Tom