From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 91240 invoked by alias); 18 Sep 2018 17:51:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 91224 invoked by uid 89); 18 Sep 2018 17:51:27 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-0.6 required=5.0 tests=BAYES_00,SPF_HELO_PASS,TRACKER_ID autolearn=no version=3.3.2 spammy=pleasure, encrypted X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 18 Sep 2018 17:51:25 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B7FC98CDC; Tue, 18 Sep 2018 17:51:24 +0000 (UTC) Received: from localhost (unused-10-15-17-196.yyz.redhat.com [10.15.17.196]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8CBC02C8FD; Tue, 18 Sep 2018 17:51:24 +0000 (UTC) From: Sergio Durigan Junior To: Joel Brobecker Cc: GDB Patches Subject: Re: [PATCH] Expect for "@" when doing "complete break ada" on gdb.ada/complete.exp References: <20180917213334.4468-1-sergiodj@redhat.com> <20180918150327.GK19172@adacore.com> Date: Tue, 18 Sep 2018 17:51:00 -0000 In-Reply-To: <20180918150327.GK19172@adacore.com> (Joel Brobecker's message of "Tue, 18 Sep 2018 08:03:27 -0700") Message-ID: <875zz2zobn.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2018-09/txt/msg00637.txt.bz2 On Tuesday, September 18 2018, Joel Brobecker wrote: > Hi Sergio, Hey Joel, > Thanks for the patch! My pleasure :-). >> Currently, gdb.ada/complete.exp's "complete break ada" test fails >> because the regexp used to match the command's output doesn't expect >> "@", but we have an output like: >> >> ... >> complete break ada >> break ada.assertions.assert >> break ada.calendar.arithmetic.difference >> break ada.calendar.arithmetic_operations.add >> break ada.calendar.arithmetic_operations.add.cold >> break ada.calendar.arithmetic_operations.add@plt >> break ada.calendar.arithmetic_operations.difference >> break ada.calendar.arithmetic_operations.difference@plt >> ... >> >> This patch adds "@" to the regexp, unbreaking the test. >> >> OK? >> >> gdb/testsuite/ChangeLog: >> 2018-09-17 Sergio Durigan Junior >> >> * gdb.ada/complete.exp: Expect for "@" when doing "complete >> break ada". > > I can see this behavior, but only when I link with the shared > version of libgnat. For us at least, on x86_64-linux, this is not > the default. That's probably why I wasn't seeing this. Ah, I see. TBH, I haven't investigate this further. I'm glad you can reproduce it there. > This is OK. Thanks, pushed. 7a6d2b458f95030f433a0dcdabd5cda7ee695a9b -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/