Re: [RFA] Fix splay tree KEY leak detected in GDB test gdb.base/macscp.exp

Kevin Buettner
2019-02-03T17:45:46Z

On Sat, 26 Jan 2019 23:34:35 +0100
Philippe Waroquiers <philippe.waroquiers@skynet.be> wrote:

> include/ChangeLog
> 2019-01-26 Philippe Waroquiers <philippe.waroquiers@skynet.be>
>
> * splay-tree.h (splay_tree_delete_key_fn): Update comment.
> (splay_tree_delete_value_fn): Likewise.
>
> libiberty/ChangeLog
> 2019-01-26 Philippe Waroquiers <philippe.waroquiers@skynet.be>
>
> * splay-tree.c (splay_tree_insert): Also release old KEY in case
> of insertion of a key equal to an already present key.
> (splay_tree_new_typed_alloc): Update comment.

These changes look reasonable to me, BUT...

I think you'll need to get approval for this patch from the gcc
maintainers. The libiberty README file indicates that fixes should be
sent to gcc-patches@gcc.gnu.org.

Kevin