From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 97532 invoked by alias); 14 Feb 2019 14:48:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 97380 invoked by uid 89); 14 Feb 2019 14:48:44 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:440 X-HELO: gateway33.websitewelcome.com Received: from gateway33.websitewelcome.com (HELO gateway33.websitewelcome.com) (192.185.146.87) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 14 Feb 2019 14:48:43 +0000 Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway33.websitewelcome.com (Postfix) with ESMTP id 74AAD1CFF17 for ; Thu, 14 Feb 2019 08:48:33 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id uIJUgPA6Q2PzOuIJUgtQni; Thu, 14 Feb 2019 08:48:33 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=xaAEuyzYd72LVwI0gKPq7y4r/ZTLsWxowuiYUSkoEAc=; b=aM/iGKzr8ctMWQ9z/1fjKaeEzT xHHoEK9q5NMI5n60fdIXixy6yii6ReQUEWZNdrxG6+mSh9MYc4kplU3hQOKmVpGsNSGuuN2nZl3jY q07PhNvZ9cUi+rnvpOzR0IP7p; Received: from 75-166-72-210.hlrn.qwest.net ([75.166.72.210]:49780 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1guIJU-000y5H-Ok; Thu, 14 Feb 2019 08:48:32 -0600 From: Tom Tromey To: John Baldwin Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 00/20] Remove cleanups References: <20190213212927.9474-1-tom@tromey.com> <75686c17-b637-2403-09ab-b362d85a9c04@FreeBSD.org> Date: Thu, 14 Feb 2019 14:48:00 -0000 In-Reply-To: <75686c17-b637-2403-09ab-b362d85a9c04@FreeBSD.org> (John Baldwin's message of "Wed, 13 Feb 2019 13:48:00 -0800") Message-ID: <875ztm4e9s.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-02/txt/msg00222.txt.bz2 >>>>> "John" == John Baldwin writes: John> The only comment I have is that the structure names for exceptions look a John> bit awkward in code now with the mix of lower and upper case, e.g.: That is a good point. I think I can easily update the exception rewriter to also rename these classes. I will take a look. Plan B is to just have a second patch to do the renaming. thanks, Tom