From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 84877 invoked by alias); 18 Mar 2019 17:10:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 84864 invoked by uid 89); 18 Mar 2019 17:10:04 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 18 Mar 2019 17:10:03 +0000 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DE05088AA2; Mon, 18 Mar 2019 17:10:01 +0000 (UTC) Received: from localhost (unused-10-15-17-196.yyz.redhat.com [10.15.17.196]) by smtp.corp.redhat.com (Postfix) with ESMTP id ABBA61001938; Mon, 18 Mar 2019 17:10:01 +0000 (UTC) From: Sergio Durigan Junior To: Eli Zaretskii Cc: slyfox@gentoo.org, tom@tromey.com, gdb-patches@sourceware.org Subject: Re: [PATCH] gdb/configure.ac: add --enable-source-highlight References: <20190313215020.11959-1-slyfox@gentoo.org> <87k1h0b4ql.fsf@tromey.com> <20190317224720.181c95af@sf> <8736nkrg8c.fsf@redhat.com> <834l80w2r6.fsf@gnu.org> Date: Mon, 18 Mar 2019 17:10:00 -0000 In-Reply-To: <834l80w2r6.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 18 Mar 2019 18:45:01 +0200") Message-ID: <875zsgp0ra.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2019-03/txt/msg00388.txt.bz2 On Monday, March 18 2019, Eli Zaretskii wrote: >> From: Sergio Durigan Junior >> Cc: Tom Tromey , gdb-patches@sourceware.org >> Date: Sun, 17 Mar 2019 23:52:51 -0400 >> >> Something Keith and I were talking about the other day is adding a >> command line switch to enable/disable source highlight, so the user can >> do: >> >> gdb --disable-source-highlight ... >> >> (or some such) > > We already have a variable, which you can set from your ~/.gdbinit, > isn't that enough? In my experience as a GDB user, it is. But I'm thinking about people who, for some reason, wouldn't like to keep (or don't know about) a ~/.gdbinit, and would like to disable the feature from the start. It's more convenient for the user to do: gdb --disable-source-highlight ... (The parameter could be named in a different, more concise way, of course) than to do: echo 'set style source off' >> ~/.gdbinit gdb ... or: gdb -ex 'set style source off' ... (IME, it's common for a user to not know about -ex) But anyway, I don't want to bikeshed over this. If it's a hard thing to do, I'm totally fine with keeping things as is. Thanks, -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/