From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 125578 invoked by alias); 3 Apr 2019 19:13:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 125561 invoked by uid 89); 3 Apr 2019 19:13:32 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00,KHOP_DYNAMIC,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.1 spammy= X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0b-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.158.5) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 03 Apr 2019 19:13:31 +0000 Received: from pps.filterd (m0098416.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x33J5uSr067507 for ; Wed, 3 Apr 2019 15:13:29 -0400 Received: from e33.co.us.ibm.com (e33.co.us.ibm.com [32.97.110.151]) by mx0b-001b2d01.pphosted.com with ESMTP id 2rn0exxua8-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 03 Apr 2019 15:13:29 -0400 Received: from localhost by e33.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 3 Apr 2019 20:13:28 +0100 Received: from b03cxnp08027.gho.boulder.ibm.com (9.17.130.19) by e33.co.us.ibm.com (192.168.1.133) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Wed, 3 Apr 2019 20:13:26 +0100 Received: from b03ledav004.gho.boulder.ibm.com (b03ledav004.gho.boulder.ibm.com [9.17.130.235]) by b03cxnp08027.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x33JDPZG55312624 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 3 Apr 2019 19:13:25 GMT Received: from b03ledav004.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5FA977805E; Wed, 3 Apr 2019 19:13:25 +0000 (GMT) Received: from b03ledav004.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 19D857805C; Wed, 3 Apr 2019 19:13:25 +0000 (GMT) Received: from pedro.localdomain (unknown [9.85.171.73]) by b03ledav004.gho.boulder.ibm.com (Postfix) with ESMTP; Wed, 3 Apr 2019 19:13:24 +0000 (GMT) Received: by pedro.localdomain (Postfix, from userid 1000) id 23EB13C042A; Wed, 3 Apr 2019 16:13:12 -0300 (-03) From: Pedro Franco de Carvalho To: Ulrich Weigand , Alan Hayward Cc: Simon Marchi , "gdb-patches\@sourceware.org" , nd Subject: Re: [PATCH 2/2] gdbserver: Add linux_get_hwcap In-Reply-To: <20190329231239.B13C9D802BE@oc3748833570.ibm.com> References: <20190329231239.B13C9D802BE@oc3748833570.ibm.com> Date: Wed, 03 Apr 2019 19:13:00 -0000 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable x-cbid: 19040319-0036-0000-0000-00000AA40656 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00010868; HX=3.00000242; KW=3.00000007; PH=3.00000004; SC=3.00000284; SDB=6.01183856; UDB=6.00619822; IPR=6.00964607; MB=3.00026282; MTD=3.00000008; XFM=3.00000015; UTC=2019-04-03 19:13:28 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19040319-0037-0000-0000-00004B425F4E Message-Id: <875zruhph3.fsf@linux.vnet.ibm.com> X-IsSubscribed: yes X-SW-Source: 2019-04/txt/msg00057.txt.bz2 Hi, I noticed that is_elfv2_inferior previously relied on ppc_get_auxv returning whether or not the AT_PHDR key is found, besides the vector value. The actual value was returned in the pointer argument. The new linux_get_auxv returns 0 for the value if the key isn't found. I don't know if the value for AT_PHDR can be an actual 0. Should linux_get_auxv be changed to return this and also take a CORE_ADDR pointer? It should also be made visible in the header. Thanks! -- Pedro Franco de Carvalho Ulrich Weigand writes: > Alan Hayward wrote: > >> I=C3=A2=C2=80=C2=99ll send out a new OBV patch with the AT_HWCAP2 added = in the same way. > > Thanks for fixing this issue. Now the build gets one file further and > then fails again :-) > > gdb/gdbserver/linux-ppc-low.c: In function 'int is_elfv2_inferior()': > gdb/gdbserver/linux-ppc-low.c:1113:8: error: 'ppc_get_auxv' was not decla= red in this scope > if (!ppc_get_auxv (AT_PHDR, &phdr)) > > This is because of: > > * linux-ppc-low.c (ppc_get_auxv): Remove function. > > You removed two callers of this function, but one more remains ... > > Bye, > Ulrich > > --=20 > Dr. Ulrich Weigand > GNU/Linux compilers and toolchain > Ulrich.Weigand@de.ibm.com